8000 Use `Environment.TickCount64` in `GetUptimeCommand` by xtqqczze · Pull Request #26151 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Use Environment.TickCount64 in GetUptimeCommand #26151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Use Environment.TickCount64 in GetUptimeCommand #26151

wants to merge 3 commits into from

Conversation

xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Oct 5, 2025 •
edited
Loading
  • Use the .NET Core 3.0 API Environment.TickCount64 instead of Stopwatch.
  • Refactor into seperate methods for the different code paths.

cc: @iSazonov

@xtqqczze
Use Environment.TickCount64 in GetUptimeCommand
76b2986 
Use the .NET Core 3.0 API `Environment.TickCount64` instead of `Stopwatch`
@xtqqczze
Extract into seperate methods
351c0d8
@xtqqczze xtqqczze mentioned this pull request Oct 5, 2025
Merged
12 tasks
@iSazonov
Copy link
Collaborator
iSazonov commented Oct 8, 2025

@xtqqczze This is more difficult area than might be expected.
See dotnet/runtime#77945
Really we could say about:

  1. absolute OS boot time
  2. how long OS works since boot time minus suspended time
  3. time from OS boot time to current time
    Ideally the cmdlet should allow users to get all these times.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 8, 2025

@iSazonov Does dotnet/runtime#77945 mean these changes are a change in behavior?

@iSazonov
Copy link
Collaborator
iSazonov commented Oct 8, 2025

Yes, this should correct the difference on different systems.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 8, 2025

So these changes are a fix for #18469?

@iSazonov
Copy link
Collaborator
iSazonov commented Oct 8, 2025

One step in this direction. What would be ideal, I described above.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 8, 2025 •
edited
Loading

The cmdlet is documented to "return the time elapsed since the last boot of the operating system"

So if these changes align with this, then I think that is sufficient for this PR.

how long OS works since boot time minus suspended time

This would be a new feature and could be implemented separately.

@iSazonov
Copy link
Collaborator
iSazonov commented Oct 9, 2025

This cmdlet was presented as an experimental one to get feedback. After some issues and user expectations have been identified, this cmdlet can be fixed as I described, but a fix in Runtime is required before.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 9, 2025

This cmdlet was presented as an experimental one to get feedback. After some issues and user expectations have been identified, this cmdlet can be fixed as I described, but a fix in Runtime is required before.

I see there is now PR: dotnet/runtime#119443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov
0