8000 Add completion for variables assigned in ArrayLiterals and ParenExpressions by MartinGC94 · Pull Request #25303 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add completion for variables assigned in ArrayLiterals and ParenExpressions #25303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Add completion for variables assigned in ArrayLiterals and ParenExpressions #25303

merged 1 commit into from
May 8, 2025

Conversation

MartinGC94
Copy link
Contributor

PR Summary

One can use array literals to deconstruct assignments like this: $Var1, $Var2 = 1..10 where $Var1 gets the first value and $var2 gets the rest.
One can also assign variables inside ParenExpressions like this: ($Var1) = 1..10 though to my knowledge this serves no practical purpose.
This PR fixes it so variable assignments made like this are included in the completion results.

PR Context

PR Checklist

@iSazonov iSazonov requested a review from Copilot April 11, 2025 04:20
@iSazonov iSazonov self-assigned this Apr 11, 2025
Copilot
Copilot AI reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1: Language not supported

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 11, 2025
@iSazonov
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@MartinGC94 MartinGC94 mentioned this pull request Apr 11, 2025
Open
12 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Apr 18, 2025
@iSazonov iSazonov merged commit 957eb1b into PowerShell:master May 8, 2025
39 of 42 checks passed
@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label May 8, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor
microsoft-github-policy-service bot commented May 8, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinGC94 @iSazonov
0