8000 Update the vmImage and PowerShell root directory for macOS builds by adityapatwardhan · Pull Request #16611 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Update the vmImage and PowerShell root directory for macOS builds #16611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2021
Merged

Update the vmImage and PowerShell root directory for macOS builds #16611

merged 3 commits into from
Dec 14, 2021

Conversation

adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Dec 13, 2021 •
edited
Loading

PR Summary

Update to use macos-latest and the vmImage for the macOS release build.
Use the Agent.TempDirectory as the Powershell root, as the AzDO recommendation.
Optionally, use the Agent.TempDirectory as PS root for macOS builds.

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Dec 13, 2021
@adityapatwardhan adityapatwardhan changed the title Update the vmImage and PowerShell root directory for macOS builds WIP: Update the vmImage and PowerShell root directory for macOS builds Dec 13, 2021
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 13, 2021
@pull-request-quantifier-deprecated
Copy link

This PR has 28 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +18 -10
Percentile : 11.2%

Total files changed: 3

Change summary by file extension:
.yml : +18 -10

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan changed the title WIP: Update the vmImage and PowerShell root directory for macOS builds Update the vmImage and PowerShell root directory for macOS builds Dec 14, 2021
@adityapatwardhan adityapatwardhan merged commit a54b9a2 into PowerShell:master Dec 14, 2021
@adityapatwardhan adityapatwardhan deleted the FixMacOsBuild2 branch December 14, 2021 00:13
TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@adityapatwardhan @TrapGodBrim
Update the vmImage and PowerShell root directory for macOS builds (P…
ea8dac9 
…owerShell#16611)
@ghost
Copy link
ghost commented Feb 24, 2022

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@adityapatwardhan @TravisEz13
Update the vmImage and PowerShell root directory for macOS builds (P…
555dabe 
…owerShell#16611)
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 14, 2022
@adityapatwardhan @TravisEz13
Update the vmImage and PowerShell root directory for macOS builds (P…
3a727eb 
…owerShell#16611)

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/mac-package-build.yml
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 15, 2022
@adityapatwardhan @TravisEz13
Update the vmImage and PowerShell root directory for macOS builds (P…
2c9a6b8 
…owerShell#16611)

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/mac-package-build.yml
@ghost
Copy link
ghost commented Mar 16, 2022

🎉v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Mar 16, 2022

🎉v7.1.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Mar 16, 2022

🎉v7.2.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels
Backport-7.0.x-Done BackPort-7.1.x-Done Backport to 7.1.x completed Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityapatwardhan @TravisEz13 @PaulHigin
0