8000 Remove all references to cmake for the builds in this repo by TravisEz13 · Pull Request #16578 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Remove all references to cmake for the builds in this repo #16578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2022
Merged

Remove all references to cmake for the builds in this repo #16578

merged 2 commits into from
Jan 26, 2022

Conversation

TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Dec 8, 2021 •
edited
Loading

PR Summary

Remove all references to cmake for the builds in this repo

PR Context

Consider backporting this so we don't install build tools we don't need.

PR Checklist

@ghost ghost assigned adityapatwardhan Dec 8, 2021
@TravisEz13 TravisEz13 marked this pull request as ready for review December 8, 2021 22:43
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 8, 2021
@ghost ghost added the Stale label Dec 24, 2021
@ghost
Copy link
ghost commented Dec 24, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Jan 3, 2022
@TravisEz13 TravisEz13 reopened this Jan 25, 2022
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Jan 25, 2022
@pull-request-quantifier-deprecated
Copy link

This PR has 37 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +10 -27
Percentile : 14.8%

Total files changed: 5

Change summary by file extension:
.psm1 : +4 -8
.md : +2 -4
.ps1 : +4 -6
tools/releaseBuild/Images/microsoft_powershell_alpine3/Dockerfile : +0 -9

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit 5e005b8 into PowerShell:master Jan 26, 2022
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 26, 2022
@ghost
Copy link
ghost commented Feb 24, 2022

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@TravisEz13
Remove all references to cmake for the builds in this repo (PowerSh…
64ff0fc 
…ell#16578)

# Conflicts:
#	build.psm1
#	test/perf/benchmarks/assets/compiler.test.ps1
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 14, 2022
@TravisEz13
Remove all references to cmake for the builds in this repo (PowerSh…
7d5fcd0 
…ell#16578)

# Conflicts:
#	build.psm1
#	test/perf/benchmarks/assets/compiler.test.ps1

# Conflicts:
#	docs/building/linux.md
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 15, 2022
@TravisEz13
Remove all references to cmake for the builds in this repo (PowerSh…
96bdcfc 
…ell#16578)

# Conflicts:
#	build.psm1
#	test/perf/benchmarks/assets/compiler.test.ps1

# Conflicts:
#	docs/building/linux.md

# Conflicts:
#	build.psm1
@ghost
Copy link
ghost commented Mar 16, 2022

🎉v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Mar 16, 2022

🎉v7.2.2 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 deleted the cleanup-bootstrap branch March 31, 2022 18:14
@TravisEz13
Copy link
Member Author

/backport to release/v7.0.11

@github-actions
Copy link
Contributor
github-actions bot commented May 4, 2022 •
edited by unfurl-links bot
Loading

Started backporting to release/v7.0.11: https://github.com/PowerShell/PowerShell/actions/runs/2271018100

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions
Copy link
Contributor
github-actions bot commented May 4, 2022

@TravisEz13 backporting to release/v7.0.11 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: remove all references to cmake for the builds in this repo
Using index info to reconstruct a base tree...
M	build.psm1
M	docs/building/linux.md
M	docs/building/macos.md
A	test/perf/benchmarks/assets/compiler.test.ps1
A	tools/releaseBuild/Images/microsoft_powershell_alpine3/Dockerfile
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/perf/benchmarks/assets/compiler.test.ps1 deleted in HEAD and modified in remove all references to cmake for the builds in this repo. Version remove all references to cmake for the builds in this repo of test/perf/benchmarks/assets/compiler.test.ps1 left in tree.
Auto-merging docs/building/macos.md
Auto-merging docs/building/linux.md
Auto-merging build.psm1
CONFLICT (content): Merge conflict in build.psm1
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 remove all references to cmake for the builds in this repo
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@TravisEz13
Copy link
Member Author

cherry-pick to 7.0 resulted in no changes

@TravisEz13
Copy link
Member Author

96bdcfc is 7.0 commit to backport

@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@adityapatwardhan adityapatwardhan

Labels
Backport-7.0.x-Done Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TravisEz13 @daxian-dbw @adityapatwardhan
0