8000 Need to support running in root privilege on Linux Travis CI similar as in AppVeyor · Issue #5645 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Need to support running in root privilege on Linux Travis CI similar as in AppVeyor #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daxian-dbw opened this issue Dec 7, 2017 · 5 comments
Closed

Need to support running in root privilege on Linux Travis CI similar as in AppVeyor #5645

daxian-dbw opened this issue Dec 7, 2017 · 5 comments
Assignees
@kalgiz
Labels
Resolution-Fixed The issue is fixed. WG-Quality-Test issues in a test or in test infrastructure

Comments

@daxian-dbw
Copy link
Member
daxian-dbw commented Dec 7, 2017 •
edited
Loading

We need to support running tests in root privilege on Linux Travis CI in a similar way as our windows tests running in AppVeyor. For windows tests, we have a tag RequireAdminOnWindows to indicate the tests that need admin privilege. We run those tests in an admin pwsh session, and then we use runas to remove admin privilege and run the rest tests.

With sudo: required in .travis.yml, Travis CI Linux builds run in regular user privilege by default, but you can get the root privilege using sudo with no need to provide a password (see the documentation). So we should be able to support a similar tag like RequireAdminOnWindows on Linux.
@daxian-dbw daxian-dbw added the WG-Quality-Test issues in a test or in test infrastructure label Dec 7, 2017
@daxian-dbw daxian-dbw mentioned this issue Dec 7, 2017
Merged
5 tasks
@TravisEz13
Copy link
Member

This change needs to use this feature to actually run these tests on linux: https://github.com/PowerShell/PowerShell/pull/6034/files/df3371990529ae64f481760f1edb7ccdbb89d9d7..ff9a0dde9d655efbe1460e0fab8e3f5dcf7ddee2

@TravisEz13 TravisEz13 mentioned this issue Jan 27, 2018
Merged
9 tasks
@iSazonov
Copy link
Collaborator

I found some tests that use Test-Elevated - I believe we should fix them too.

@dantraMSFT dantraMSFT mentioned this issue Feb 5, 2018
Merged
9 tasks
@iSazonov iSazonov mentioned this issue Feb 7, 2018
Closed
7 tasks
@anmenaga
Copy link
anmenaga commented Feb 9, 2018

Can somebody please confirm/deny if the fix for this won't be limited to "Travis CI" system?
I'm talking about a scenario where I run PS tests on a private Linux VM.
Assuming tests are marked properly, will they run with admin privilege in this case?

@TravisEz13
Copy link
Member

you could use the same commands to run locally. The same situation as with windows today.

@TravisEz13 TravisEz13 mentioned this issue Feb 13, 2018
Closed
@kalgiz
Copy link
Contributor
kalgiz commented Feb 16, 2018

Resolved in #6145 PR.

@kalgiz kalgiz closed this as completed Feb 16, 2018
@iSazonov iSazonov added the Resolution-Fixed The issue is fixed. label Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalgiz kalgiz

Labels
Resolution-Fixed The issue is fixed. WG-Quality-Test issues in a test or in test infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@daxian-dbw @kalgiz @TravisEz13 @anmenaga @iSazonov
0