8000 Default User Agent Reports WindowsPowerShell · Issue #4911 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Default User Agent Reports WindowsPowerShell #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markekraus opened this issue Sep 24, 2017 · 1 comment · Fixed by #4914
Closed

Default User Agent Reports WindowsPowerShell #4911

markekraus opened this issue Sep 24, 2017 · 1 comment · Fixed by #4914
Labels
Resolution-Fixed The issue is fixed. Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors WG-Cmdlets-Utility cmdlets in the Microsoft.PowerShell.Utility module
Milestone
6.0.0-GA

Comments

@markekraus
Copy link
Contributor
markekraus commented Sep 24, 2017 •
edited
Loading

PowerShell/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/PSUserAgent.cs

Line 116 in 1c921cd

"WindowsPowerShell/{0}", PSVersionInfo.PSVersion);

This should be just PowerShell and not WindowsPowerShell.

Steps to reproduce

$bingdings = [System.Reflection.BindingFlags]::NonPublic -bxor [System.Reflection.BindingFlags]::Static
[Microsoft.PowerShell.Commands.PSUserAgent].GetProperty('App',$bingdings).GetValue($null,$null)

Expected behavior

PowerShell/6.0.0

Actual behavior

WindowsPowerShell/6.0.0

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.7
OS                             Microsoft Windows 10.0.15063
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

and

Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.7
OS                             Linux 4.4.0-96-generic #119-Ubuntu SMP Tue Se...
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Note on changing this

There are several tests, like the one below, which will also need to be updated.

PowerShell/test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1

Line 466 in 1c921cd

$jsonContent.headers.'User-Agent' | Should Match "WindowsPowerShell"

@SteveL-MSFT
Copy link
Member < 8000 /div>

I think it should be just "PowerShell/6.0.0"

@SteveL-MSFT SteveL-MSFT added WG-Cmdlets-Utility cmdlets in the Microsoft.PowerShell.Utility module Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors labels Sep 24, 2017
@SteveL-MSFT SteveL-MSFT added this to the 6.0.0-HighPriority milestone Sep 24, 2017
@markekraus markekraus changed the title Default User Agent reports WindowsPowerShell Default User Agent Reports WindowsPowerShell Sep 24, 2017
@markekraus markekraus mentioned this issue Sep 25, 2017
Merged
@iSazonov iSazonov added the Resolution-Fixed The issue is fixed. label Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution-Fixed The issue is fixed. Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors WG-Cmdlets-Utility cmdlets in the Microsoft.PowerShell.Utility module
Projects
None yet
Milestone
6.0.0-GA
Development

Successfully merging a pull request may close this issue.

Change UserAgent App WindowsPowerShell -> PowerShell markekraus/PowerShell
3 participants
@markekraus @SteveL-MSFT @iSazonov
0