8000 Several messages have 2 spaces between words · Issue #4740 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Several messages have 2 spaces between words #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
korygill opened this issue Sep 2, 2017 · 3 comments
Closed

Several messages have 2 spaces between words #4740

korygill opened this issue Sep 2, 2017 · 3 comments
Labels
Issue-Bug Issue has been identified as a bug in the product Resolution-Fixed The issue is fixed.

Comments

@korygill
Copy link
Contributor
korygill commented Sep 2, 2017

Steps to reproduce

Run a script from non-elevated that requires admin, for example.

...Start Windows PowerShell by  using the Run as Administrator option...
..............................^^

Or just look at the change and see the issue.

Expected behavior

Messages should have 1 space between words.
(I did not fix all the "\w+ \w+" errors in all the other, non resx files...)

Actual behavior

Some messages have 2 space between words.

Environment data

PSVersion 5.1.15063.502
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.15063.502
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
@korygill korygill mentioned this issue Sep 2, 2017
Merged
@iSazonov
Copy link
Collaborator
iSazonov commented Sep 2, 2017

@korygill Thanks for your contribution!

Could you please clarify (samples):

(I did not fix all the "\w+ \w+" errors in all the other, non resx files...)

@korygill
Copy link
Contributor Author
korygill commented Sep 2, 2017

@iSazonov what I mean is there are more instances of 2 spaces between words (~401 hits in 143 files) but most, if not all, appear in comments on non-user-facing strings, so no need to fix those necessarily. If someone wanted to do this, they could search for "\w+ \w+" in the files using any regex/editor like notepad++ under src and see them.

@iSazonov
Copy link
Collaborator
iSazonov commented Sep 3, 2017 •
edited
Loading

@korygill Thanks for clarify!

@TravisEz13 Should we fix such typos and add the check to meta tests?
Update: @SteveL-MSFT pushed #4743 to fix the typos - so one question - should we add the meta test?

@iSazonov iSazonov added Issue-Bug Issue has been identified as a bug in the product Resolution-Fixed The issue is fixed. labels Sep 3, 2017
@iSazonov iSazonov closed this as completed Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug Issue has been identified as a bug in the product Resolution-Fixed The issue is fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@korygill @iSazonov
0