8000 Address Code Cleanup Comments in PR #4318 · Issue #4596 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Address Code Cleanup Comments in PR #4318 #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mirichmo opened this issue Aug 16, 2017 · 0 comments
Closed

Address Code Cleanup Comments in PR #4318 #4596

mirichmo opened this issue Aug 16, 2017 · 0 comments
Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Resolution-Fixed The issue is fixed.

Comments

@mirichmo
Copy link
Member

There are a few small code clean up comments that were not addressed in the PR. This issue documents them in case someone wants to pick up the task.

src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/ConvertToJsonCommand.cs
@@ -60,6 +61,15 @@ public class ConvertToJsonCommand : PSCmdlet
[Parameter]
public SwitchParameter Compress { get; set; }

  •    /// <summary> 

  •    /// gets or sets the EnumsAsStrings property.

Please correct typo gets -> Gets.

test/powershell/Modules/Microsoft.PowerShell.Utility/Pester.Commands.Cmdlets.Json.Tests.ps1
+

  •        $response4 = ConvertTo-Json -InputObject $sampleObject -Compress -EnumsAsStrings 

  •        $response4 | Should Be '{"SampleSimpleEnum":"Ignore","SampleBitwiseEnum":"Alias, Function, Cmdlet"}'

Please remove extra line.

test/powershell/Modules/Microsoft.PowerShell.Utility/Pester.Commands.Cmdlets.Json.Tests.ps1

  •        $response4 | Should Be '{"SampleSimpleEnum":"Ignore","SampleBitwiseEnum":"Alias, Function, Cmdlet"}' 

  •    }

Please remove extra line.
@mirichmo mirichmo mentioned this issue Aug 16, 2017
Merged
@iSazonov iSazonov added Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Resolution-Fixed The issue is fixed. labels Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Resolution-Fixed The issue is fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirichmo @iSazonov
0