8000 PSVersion in `$PSVersionTable` is hard-coded in PSVersionInfo.cs · Issue #3739 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

PSVersion in $PSVersionTable is hard-coded in PSVersionInfo.cs #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daxian-dbw opened this issue May 9, 2017 · 2 comments
Closed

PSVersion in $PSVersionTable is hard-coded in PSVersionInfo.cs #3739

daxian-dbw opened this issue May 9, 2017 · 2 comments
Assignees
@iSazonov
Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Resolution-Fixed The issue is fixed. WG-Engine core PowerShell engine, interpreter, and runtime
Milestone
6.0.0-NiceToHave

Comments

@daxian-dbw
Copy link
Member

private static SemanticVersion s_psV6Version = new SemanticVersion(6, 0, 0, "alpha");

It should not be a hard-coded, but instead should be generated based on the GitCommitId.
@daxian-dbw daxian-dbw added the WG-Engine core PowerShell engine, interpreter, and runtime label May 9, 2017
@daxian-dbw daxian-dbw added this to the 6.0.0-beta milestone May 9, 2017
@daxian-dbw daxian-dbw mentioned this issue May 9, 2017
Merged
@iSazonov iSazonov mentioned this issue May 10, 2017
Closed
@iSazonov
Copy link
Collaborator

@daxian-dbw I can fix this in #3690

@TravisEz13 TravisEz13 changed the title PSVersion in $PSVertionTable is hard-coded in PSVersionInfo.cs PSVersion in $PSVersionTable is hard-coded in PSVersionInfo.cs May 10, 2017
@SteveL-MSFT SteveL-MSFT modified the milestones: 6.0.0-beta, 6.0.0 May 15, 2017
@iSazonov
Copy link
Collaborator
iSazonov commented Jun 2, 2017

We agreed to break #3690 down into a few small parts.

@SteveL-MSFT SteveL-MSFT added the Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality label Jun 4, 2017
@iSazonov iSazonov mentioned this issue Sep 19, 2017
Merged
@iSazonov iSazonov added the Resolution-Fixed The issue is fixed. label Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iSazonov iSazonov

Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Resolution-Fixed The issue is fixed. WG-Engine core PowerShell engine, interpreter, and runtime
Projects
None yet
Milestone
6.0.0-NiceToHave
Development

No branches or pull requests
3 participants
@daxian-dbw @SteveL-MSFT @iSazonov
0