8000 Move to new Pester version · Issue #3002 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Move to new Pester version #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iSazonov opened this issue Jan 13, 2017 · 11 comments
Closed

Move to new Pester version #3002

iSazonov opened this issue Jan 13, 2017 · 11 comments
Labels
Resolution-Fixed The issue is fixed. WG-Quality-Test issues in a test or in test infrastructure
Milestone
6.0.0-NiceToHave

Comments

@iSazonov
Copy link
Collaborator

Now Pester v3.4.5 support output filters pester/Pester#645. We can use this to reduce the CI output.

Currently we use very old Pester version 3.3.9 (May 23, 2015) so perhaps the time has come to move to new version.
@mirichmo
Copy link
Member
mirichmo commented Jan 17, 2017 •
edited
Loading

@JamesWTruher and @adityapatwardhan - Have you guys investigated moving to a later version of Pester?

@mirichmo mirichmo added the WG-Quality-Test issues in a test or in test infrastructure label Jan 17, 2017
@SteveL-MSFT SteveL-MSFT modified the milestones: 6.0.0-beta, 6.0.0 Mar 5, 2017
@iSazonov
Copy link
Collaborator Author

@joeyaiello I wonder shall we distribute PowerShell 6 RTM with old Pester? Should we add this in Plan?

@joeyaiello
Copy link
Contributor

As far as I understood from @JamesWTruher, the plan was always to be conservative with picking up new versions of Pester. Basically, that we shouldn't ship a new one unless we had a reason to pick up the new stuff.

It may very well be the case that we need to do that, but I'd like Jim to come in and make sure I've got the history right first.

@iSazonov
Copy link
Collaborator Author

I agree that conservatism here is good. But two years is too much.

There is another problem. If Windows users can easily upgrade Pester and exploit new features, the Unix users cannot do this. This is really a problem for those who want to be fully ported.

@iSazonov
Copy link
Collaborator Author

Related #1371

@SteveL-MSFT
Copy link
Member

cc @JamesWTruher

@JamesWTruher
Copy link
Collaborator
JamesWTruher commented Nov 14, 2017 •
edited
Loading

I've been looking at Pester 4.0.8 and it looks really great. Lot's of excellent improvements; First and foremost handling our cross-plat needs, but it's not completely backwardly compatible, and I get more than 100 test failures when I run our tests using 4.0.8. I've got a big bunch of them fixed and all of those are test issues, but it's taking a bit of time to track them all down.

The issues boil down to a couple of things - missing/changed assertions (Contains/FileContentMatch), Be actually working against arrays (awesome), and tests which never actually worked, and because error checking has improved to catch them, like Should Throw which now complains if it doesn't get a scriptblock, those tests are properly failing.

I do look forward to the time when we can just grab this and dump our submodule and it shouldn't be too long now. @dlwyatt Is there any thought of making this a nupkg?

@dlwyatt
Copy link
Contributor
dlwyatt commented Nov 14, 2017

@JamesWTruher Pester is published to nuget.org, Chocolatey and the PowerShell Gallery. Technically all three of those are nuget feeds; take your pick. :)

@JamesWTruher
Copy link
Collaborator

@dlwyatt awesome!

@iSazonov iSazonov mentioned this issue Jan 6, 2018
Closed
@it-praktyk
Copy link
Contributor

Pester since v. 4.1.0 is supported at PSCore 6.0 for all platforms (Linux, macOS, Windows - in alphabetical order).

@iSazonov
Copy link
Collaborator Author
iSazonov commented Feb 9, 2018

Fixed in #6064

@iSazonov iSazonov closed this as completed Feb 9, 2018
@iSazonov iSazonov added the Resolution-Fixed The issue is fixed. label Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution-Fixed The issue is fixed. WG-Quality-Test issues in a test or in test infrastructure
Projects
None yet
Milestone
6.0.0-NiceToHave
Development

No branches or pull requests
7 participants
@joeyaiello @it-praktyk @dlwyatt @JamesWTruher @SteveL-MSFT @mirichmo @iSazonov
0