[Feature] Create Headers Only Once and Only If Called

markekraus · markekraus · commit ec282245c33c · 2017-09-16T13:40:09.000-05:00
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/CoreCLR/WebResponseObject.CoreClr.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/CoreCLR/WebResponseObject.CoreClr.cs
@@ -31,23 +31,28 @@ public Dictionary<string, IEnumerable<string>> Headers
         {
             get
             {
-                var headers = new Dictionary<string, IEnumerable<string>>(StringComparer.OrdinalIgnoreCase);
-                foreach (var entry in BaseResponse.Headers)
+                if(headers == null)
                 {
-                    headers[entry.Key] = entry.Value;
-                }
-                if (BaseResponse.Content != null)
-                {
-                    foreach (var entry in BaseResponse.Content.Headers)
+                    headers = new Dictionary<string, IEnumerable<string>>(StringComparer.OrdinalIgnoreCase);
+                    foreach (var entry in BaseResponse.Headers)
                     {
                         headers[entry.Key] = entry.Value;
                     }
+                    if (BaseResponse.Content != null)
+                    {
+                        foreach (var entry in BaseResponse.Content.Headers)
+                        {
+                            headers[entry.Key] = entry.Value;
+                        }
+                    }
                 }
 
                 return headers;
             }
         }
 
+        private Dictionary<string, IEnumerable<string>> headers = null;
+        
         /// <summary>
         /// gets the RelationLink property
         /// </summary>

Original file line number	Diff line number	Diff line change
`@@ -31,23 +31,28 @@ public Dictionary<string, IEnumerable<string>> Headers`
`31`	`31`	`{`
`32`	`32`	`get`
`33`	`33`	`{`
`34`		`- var headers = new Dictionary<string, IEnumerable<string>>(StringComparer.OrdinalIgnoreCase);`
`35`		`- foreach (var entry in BaseResponse.Headers)`
	`34`	`+ if(headers == null)`
`36`	`35`	`{`
`37`		`- headers[entry.Key] = entry.Value;`
`38`		`- }`
`39`		`- if (BaseResponse.Content != null)`
`40`		`- {`
`41`		`- foreach (var entry in BaseResponse.Content.Headers)`
	`36`	`+ headers = new Dictionary<string, IEnumerable<string>>(StringComparer.OrdinalIgnoreCase);`
	`37`	`+ foreach (var entry in BaseResponse.Headers)`
`42`	`38`	`{`
`43`	`39`	`headers[entry.Key] = entry.Value;`
`44`	`40`	`}`
	`41`	`+ if (BaseResponse.Content != null)`
	`42`	`+ {`
	`43`	`+ foreach (var entry in BaseResponse.Content.Headers)`
	`44`	`+ {`
	`45`	`+ headers[entry.Key] = entry.Value;`
	`46`	`+ }`
	`47`	`+ }`
`45`	`48`	`}`
`46`	`49`
`47`	`50`	`return headers;`
`48`	`51`	`}`
`49`	`52`	`}`
`50`	`53`
	`54`	`+ private Dictionary<string, IEnumerable<string>> headers = null;`
	`55`	`+`
`51`	`56`	`/// <summary>`
`52`	`57`	`/// gets the RelationLink property`
`53`	`58`	`/// </summary>`