minor symfony#51370 [HttpFoundation] Add a slightly more verbose comment about a warning on UploadedFile (fabpot)

chalasr · chalasr · commit 400ee5cf75da · 2023-08-14T01:28:10.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] Add a slightly more verbose comment about a warning on UploadedFile | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | n/a | License | MIT | Doc PR | n/a Refs symfony#49283 Commits ------- 28451b2 [HttpFoundation] Add a slightly more verbose comment about a warning on UploadedFile
diff --git a/src/Symfony/Component/HttpFoundation/File/UploadedFile.php b/src/Symfony/Component/HttpFoundation/File/UploadedFile.php
@@ -74,7 +74,7 @@ public function __construct(string $path, string $originalName, string $mimeType
      * Returns the original file name.
      *
      * It is extracted from the request from which the file has been uploaded.
-     * Then it should not be considered as a safe value.
+     * This should not be considered as a safe value to use for a file name on your servers.
      *
      * @return string
      */
@@ -87,7 +87,7 @@ public function getClientOriginalName()
      * Returns the original file extension.
      *
      * It is extracted from the original file name that was uploaded.
-     * Then it should not be considered as a safe value.
+     * This should not be considered as a safe value to use for a file name on your servers.
      *
      * @return string
      */

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public function __construct(string $path, string $originalName, string $mimeType`
`74`	`74`	`* Returns the original file name.`
`75`	`75`	`*`
`76`	`76`	`* It is extracted from the request from which the file has been uploaded.`
`77`		`- * Then it should not be considered as a safe value.`
	`77`	`+ * This should not be considered as a safe value to use for a file name on your servers.`
`78`	`78`	`*`
`79`	`79`	`* @return string`
`80`	`80`	`*/`
`@@ -87,7 +87,7 @@ public function getClientOriginalName()`
`87`	`87`	`* Returns the original file extension.`
`88`	`88`	`*`
`89`	`89`	`* It is extracted from the original file name that was uploaded.`
`90`		`- * Then it should not be considered as a safe value.`
	`90`	`+ * This should not be considered as a safe value to use for a file name on your servers.`
`91`	`91`	`*`
`92`	`92`	`* @return string`
`93`	`93`	`*/`