8000 Make Hystrix Command names more unique · Issue #434 · OpenFeign/feign · GitHub
[go: up one dir, main page]

Skip to content

Make Hystrix Command names more unique #434

@ryanjbaxter

Description

@ryanjbaxter

By default Feign will create Hystrix Commands that use the method name as the key. It is possible to have two Feign clients with the same method names that are completely separate Hystrix Commands. However since the the method names are the same the underlying Hystrix Command cache will see these both as the same command. We can do a little better at our default key naming convention by including the class name in the key we use as well.

This should be a simple change in the code here
https://github.com/OpenFeign/feign/blob/master/hystrix/src/main/java/feign/hystrix/HystrixInvocationHandler.java#L90

For more information see the discussion in this issue in the Hystrix project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0