[rush-lib] Fix issue with MaxListenersExceeded while using the HTTP build cache plugin (microsoft#5073)

D4N14L · web-flow · commit e5560f28caf0 · 2025-01-09T13:57:26.000-08:00
* Remove the socket error handler for WebClient

* Rush change

* Remove unused import

---------

Co-authored-by: Daniel &lt;D4N14L@users.noreply.github.com&gt;
diff --git a/common/changes/@microsoft/rush/user-danade-RemoveSocketErrorHandler_2025-01-09-20-04.json b/common/changes/@microsoft/rush/user-danade-RemoveSocketErrorHandler_2025-01-09-20-04.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where MaxListenersExceeded would get thrown when using the HTTP build cache plugin",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/src/utilities/WebClient.ts b/libraries/rush-lib/src/utilities/WebClient.ts
@@ -6,7 +6,6 @@ import * as process from 'process';
 import type * as http from 'http';
 import { request as httpRequest, type IncomingMessage } from 'node:http';
 import { request as httpsRequest, type RequestOptions } from 'node:https';
-import type { Socket } from 'node:net';
 import { Import, LegacyAdapters } from '@rushstack/node-core-library';
 
 const createHttpsProxyAgent: typeof import('https-proxy-agent') = Import.lazy('https-proxy-agent', require);
@@ -199,11 +198,6 @@ const makeRequestAsync: FetchFn = async (
           resolve(result);
         });
       })
-        .on('socket', (socket: Socket) => {
-          socket.on('error', (error: Error) => {
-            reject(error);
-          });
-        })
         .on('error', (error: Error) => {
           reject(error);
         })
