minor symfony#38649 [HttpClient] skip Vulcain-based tests if the binary cannot be executed (xabbuh)

Nyholm · Nyholm · commit e731e3710940 · 2020-10-21T00:16:26.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] skip Vulcain-based tests if the binary cannot be executed | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- fa265c2 skip Vulcain-based tests if the binary cannot be executed
diff --git a/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php
@@ -169,6 +169,14 @@ private function getVulcainClient(): CurlHttpClient
         sleep('\\' === \DIRECTORY_SEPARATOR ? 10 : 1);
 
         if (!$process->isRunning()) {
+            if ('\\' !== \DIRECTORY_SEPARATOR && 127 === $process->getExitCode()) {
+                $this->markTestSkipped('vulcain binary is missing');
+            }
+
+            if ('\\' !== \DIRECTORY_SEPARATOR && 126 === $process->getExitCode()) {
+                $this->markTestSkipped('vulcain binary is not executable');
+            }
+
             throw new ProcessFailedException($process);
         }
 
