minor symfony#48006 [DomCrawler] remove duplicated catch block (PhilETaylor)

fabpot · fabpot · commit 94dc76232f4b · 2022-10-27T08:38:01.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [DomCrawler] remove duplicated catch block | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Exception '\PHPUnit\Framework\Error\Notice' is already caught - this PR deletes unused/unreachable code. Before: ```php try { $crawler = $this->createCrawler('<p></p>'); $crawler->filter('p')->children(); $this->assertTrue(true, '->children() does not trigger a notice if the node has no children'); } catch (\PHPUnit\Framework\Error\Notice $e) { $this->fail('->children() does not trigger a notice if the node has no children'); } catch (\PHPUnit\Framework\Error\Notice $e) { $this->fail('->children() does not trigger a notice if the node has no children'); } ``` After ```php try { $crawler = $this->createCrawler('<p></p>'); $crawler->filter('p')->children(); $this->assertTrue(true, '->children() does not trigger a notice if the node has no children'); } catch (\PHPUnit\Framework\Error\Notice $e) { $this->fail('->children() does not trigger a notice if the node has no children'); } ``` Commits ------- dc40fb5 remove duplicated catch block
diff --git a/src/Symfony/Component/DomCrawler/Tests/AbstractCrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/AbstractCrawlerTest.php
@@ -1072,8 +1072,6 @@ public function testChildren()
             $this->assertTrue(true, '->children() does not trigger a notice if the node has no children');
         } catch (\PHPUnit\Framework\Error\Notice $e) {
             $this->fail('->children() does not trigger a notice if the node has no children');
-        } catch (\PHPUnit\Framework\Error\Notice $e) {
-            $this->fail('->children() does not trigger a notice if the node has no children');
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1072,8 +1072,6 @@ public function testChildren()`
`1072`	`1072`	`$this->assertTrue(true, '->children() does not trigger a notice if the node has no children');`
`1073`	`1073`	`} catch (\PHPUnit\Framework\Error\Notice $e) {`
`1074`	`1074`	`$this->fail('->children() does not trigger a notice if the node has no children');`
`1075`		`- } catch (\PHPUnit\Framework\Error\Notice $e) {`
`1076`		`- $this->fail('->children() does not trigger a notice if the node has no children');`
`1077`	`1075`	`}`
`1078`	`1076`	`}`
`1079`	`1077`