did LR raise a warning?

NicolasHug · NicolasHug · commit 93956cbfc3da · 2020-04-09T10:28:16.000-04:00
diff --git a/sklearn/tests/test_gonna_be_removed_dont_worry.py b/sklearn/tests/test_gonna_be_removed_dont_worry.py
@@ -4,19 +4,20 @@
 import warnings
 
 import pytest
-from sklearn.linear_model import LogisticRegression
+from sklearn.experimental import enable_hist_gradient_boosting  # noqa
+from sklearn.ensemble import HistGradientBoostingClassifier
 from sklearn.exceptions import SkipTestWarning
 from sklearn.utils.estimator_checks import check_estimator
 
 
 def test_strict_mode():
 
-    lr = LogisticRegression()
+    est = HistGradientBoostingClassifier(max_iter=10, min_samples_leaf=1)
     with pytest.warns(SkipTestWarning):
         # some_strict_check() was skipped
-        check_estimator(lr, strict_mode=False)
+        check_estimator(est, strict_mode=False)
 
     with warnings.catch_warnings(record=True) as w:
         # some_strict_check() was ran
-        check_estimator(lr, strict_mode=True)
-        assert not w
+        check_estimator(est, strict_mode=True)
+    assert not w
diff --git a/sklearn/utils/estimator_checks.py b/sklearn/utils/estimator_checks.py
@@ -2989,7 +2989,7 @@ def wrapper(*args, **kwargs):
             return check(*args, **kwargs)
         else:
             raise SkipTest(
-                f"strict mode is on and {check} is marked as strict"
+                f"strict mode is off and {check} is marked as strict"
             )
     return wrapper
 

Original file line number	Diff line number	Diff line change
`@@ -2989,7 +2989,7 @@ def wrapper(args, *kwargs):`
`2989`	`2989`	`return check(args, *kwargs)`
`2990`	`2990`	`else:`
`2991`	`2991`	`raise SkipTest(`
`2992`		`- f"strict mode is on and {check} is marked as strict"`
	`2992`	`+ f"strict mode is off and {check} is marked as strict"`
`2993`	`2993`	`)`
`2994`	`2994`	`return wrapper`
`2995`	`2995`