[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to get offsetHeight of undefined #57

Closed
vamp opened this issue Dec 2, 2015 · 2 comments
Closed

Trying to get offsetHeight of undefined #57

vamp opened this issue Dec 2, 2015 · 2 comments
Labels
bug

Comments

@vamp
Copy link
vamp commented Dec 2, 2015

Math.ceil(nodes.length / 2) not works correctly when nodes.length === 1
@NeXTs
Copy link
Owner
NeXTs commented Dec 2, 2015

Hi Denis
That's a good catch! Thank you, I will fix and update it later today

@NeXTs NeXTs added the bug label Dec 2, 2015
@vamp
Copy link
Author
vamp commented Dec 2, 2015

@NeXTs, thanks!
p.s. didn't like to write some code in 3d-party scripts, so my solution was:

Clusterize.prototype.getRowsHeight = (function(underlying){
  return function(){
    var ceil = Math.ceil;
    Math.ceil = Math.floor;
    var returnValue = underlying.apply(this, arguments);
    Math.ceil = ceil;
    return returnValue;
  };
})(Clusterize.prototype.getRowsHeight)

@NeXTs NeXTs closed this as completed in 21912dc Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vamp @NeXTs