[Refactor] Add additional command change and update dependencies

lindyhopchris · lindyhopchris · commit 338c046e9c80 · 2017-09-02T14:44:06.000+01:00
diff --git a/composer.json b/composer.json
@@ -69,7 +69,7 @@
             }
         }
     },
-    "minimum-stability": "dev",
+    "minimum-stability": "stable",
     "prefer-stable": true,
     "config": {
         "sort-packages": true
diff --git a/docs/upgrade.md b/docs/upgrade.md
@@ -9,7 +9,13 @@ $ composer require cloudcreativity/laravel-json-api:^0.11 --update-with-dependen
 
 ## Upgrading to 0.11 from 0.10
 
-Version `0.11` now supports Laravel 5.5.
+Version `0.11` now supports Laravel 5.5 in addition to 5.4.
+
+### Package Discovery
+
+If you are on Laravel 5.5, you no longer need to add the service provider and facade to your `app.php` config as
+we have added package discovery configuration. Feel free to remove the service provider and facade from your
+config file.
 
 ### Testing
 
diff --git a/src/Console/Commands/AbstractGeneratorCommand.php b/src/Console/Commands/AbstractGeneratorCommand.php
@@ -90,26 +90,17 @@ public function __construct(Filesystem $files, Repository $apiRepository)
 
     /**
      * @return bool|null
-     * @todo this maintains support for Laravel 5.4 - remove when no longer supporting 5.4
      */
-    public function fire()
+    public function handle()
     {
         if (!$this->apiRepository->exists($api = $this->argument('api'))) {
             $this->error("JSON API '$api' does not exist.");
             return 1;
         }
 
-        return (parent::fire() !== false) ? 0 : 1;
-    }
-
-    /**
-     * @return bool|null
-     */
-    public function handle()
-    {
-        if (!$this->apiRepository->exists($api = $this->argument('api'))) {
-            $this->error("JSON API '$api' does not exist.");
-            return 1;
+        /** @todo remove when removing support for Laravel 5.4 */
+        if (is_callable(['parent', 'fire'])) {
+            return (parent::fire() !== false) ? 0 : 1;
         }
 
         return (parent::handle() !== false) ? 0 : 1;

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`	`},`
`72`		`- "minimum-stability": "dev",`
	`72`	`+ "minimum-stability": "stable",`
`73`	`73`	`"prefer-stable": true,`
`74`	`74`	`"config": {`
`75`	`75`	`"sort-packages": true`