8000 chore: Nx 21.2 by NathanWalker · Pull Request #152 · NativeScript/angular · GitHub
[go: up one dir, main page]

Skip to content

chore: Nx 21.2 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: nx migrate latest
  • Loading branch information
NathanWalker committed Jun 15, 2025
commit a42a1caca38b489a7f4b83abe8e1e86b00132cf3
2 changes: 1 addition & 1 deletion apps/nativescript-demo-ng/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": "../../.eslintrc.json",
"ignorePatterns": ["!**/*", "node_modules/**/*", "platforms/**/*"],
"ignorePatterns": ["!**/*", "node_modules/**/*", "platforms/**/*", "src/tests/spans.spec.ts"],
"overrides": [
{
"files": ["*.ts"],
Expand Down
5 changes: 4 additions & 1 deletion apps/nativescript-demo-ng/src/tests/spans.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
/* eslint-disable */
/**
* Note: we disable eslint on this test due to:
* Parsing error: Unexpected character "EOF" (Do you have an unescaped "{" in your template? Use "{{ '{' }}") to escape it.) related to dynamic element names.
*/
import { Component, ElementRef, NO_ERRORS_SCHEMA, ViewChild } from '@angular/core';
import { TestBed } from '@angular/core/testing';
import { NativeScriptModule } from '@nativescript/angular';
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/src/lib/cdk/dialog/dialog-ref.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class NativeDialogRef<T, R = any> {
filter((event) => event.state === 'closing'),
take(1)
)
.subscribe((event) => {
.subscribe(() => {
this._beforeClosed.next(dialogResult);
this._beforeClosed.complete();
this._nativeModalRef.dispose();
Expand Down
1 change: 1 addition & 0 deletions packages/zone-js/dist/nativescript-globals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// api.patchClass('IntersectionObserver');
// });

/* eslint-disable @typescript-eslint/no-explicit-any */
Zone.__load_patch('nativescript_FileReader', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
const reader = global['FileReader'];
if (reader) {
Expand Down
0