fix(core): unregress bindable.updateOptions()

shirakaba · shirakaba · commit fa18c05a2db0 · 2024-05-01T00:28:12.000+09:00
diff --git a/packages/core/ui/core/bindable/index.ts b/packages/core/ui/core/bindable/index.ts
@@ -635,8 +635,9 @@ export class Binding {
 
 		try {
 			if (isEventOrGesture(options.property, <any>optionsInstance) && types.isFunction(value)) {
-				// calling off method with null as handler will remove all handlers for options.property event
-				optionsInstance.off(options.property, null, optionsInstance.bindingContext);
+				// Calling Observable.prototype.off() with just the event name will
+				// remove all handlers under that event name.
+				optionsInstance.off(options.property);
 				optionsInstance.on(options.property, value, optionsInstance.bindingContext);
 			} else if (optionsInstance instanceof Observable) {
 				optionsInstance.set(options.property, value);
