8000 Adding autoupdate files even when updater is disabled · Issue #484 · NativePHP/laravel · GitHub
[go: up one dir, main page]
Skip to content

Adding autoupdate files even when updater is disabled #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JapSeyz opened this issue Jan 30, 2025 · 1 comment
Open

Adding autoupdate files even when updater is disabled #484

JapSeyz opened this issue Jan 30, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@JapSeyz
Copy link
JapSeyz commented Jan 30, 2025

What were you trying to do?

Hey,

Is it intentional that when running php artisan navtivescript:build linux, with the .env key NATIVEPHP_UPDATER_ENABLED=false (I also tried just hardcoding it to false in the config)

The build segment takes a significant amount of time to "add autoupdate files"?
Image

What happened?

I spent quite a long time adding "autoupdate files", even when the auto-update feature is disabled

How to reproduce the bug

Try to build for Linux with auto-update disabled

Package Versions

{
    "installed": [
        {
            "name": "nativephp/electron",
            "direct-dependency": true,
            "homepage": "https://github.com/nativephp/electron",
            "source": "https://github.com/NativePHP/electron/tree/0.8.7",
            "version": "0.8.7",
            "description": "Electron wrapper for the NativePHP framework.",
            "abandoned": false
        },
        {
            "name": "nativephp/laravel",
            "direct-dependency": false,
            "homepage": "https://github.com/nativephp/laravel",
            "source": "https://github.com/NativePHP/laravel/tree/0.7.0",
            "version": "0.7.0",
            "description": "Laravel wrapper for the NativePHP framework.",
            "abandoned": false
        },
        {
            "name": "nativephp/php-bin",
            "direct-dependency": false,
            "homepage": "https://nativephp.com",
            "source": "https://github.com/NativePHP/php-bin/tree/0.5.6",
            "version": "0.5.6",
            "description": "PHP binaries used by the NativePHP framework",
            "abandoned": false
        }
    ]
}

PHP Version

8.2.0

Laravel Version

v11.41.3

Node Version

22.9

Which operating systems have you seen this occur on?

macOS

OS version

Sequoia 15.1.1 (24B91)

Notes

No response
@JapSeyz JapSeyz added the bug Something isn't working label Jan 30, 2025
This was referenced Feb 4, 2025
Closed
Closed
Closed
@simonhamp simonhamp marked this as a duplicate of #485 Feb 10, 2025
@simonhamp simonhamp marked this as a duplicate of #486 Feb 10, 2025
@simonhamp simonhamp marked this as a duplicate of #487 Feb 10, 2025
@simonhamp
Copy link
Member

If you disable the updater config entirely in the electron-builder.js, does it still try to do this?

Edit vendor/nativephp/electron/resources/js/electron-builder.js like so:

    appImage: {
        artifactName: appName + '-${version}.${ext}',
    },
    npmRebuild: false,
-    publish: updaterConfig,
+    // publish: updaterConfig,
    extraMetadata: {
        name: fileName,
        homepage: appUrl,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonhamp @JapSeyz
0