Fix Auto ordering of variables-section when dependent variables (#742)

snakefoot · web-flow · commit f4fd0efeeb62 · 2024-04-30T20:29:48.000+02:00
diff --git a/src/NLog.Extensions.Logging/Config/NLogLoggingConfiguration.cs b/src/NLog.Extensions.Logging/Config/NLogLoggingConfiguration.cs
@@ -349,7 +349,7 @@ private IEnumerable<IConfigurationSection> GetVariablesChildren(IConfigurationSe
                             continue;
 
                         var independentVariable = true;
-                        for (int j = i - 1; j >= 0; j--)
+                        for (int j = sortVariables.Count - 1; j >= 0; j--)
                         {
                             var otherConfigKey = sortVariables[j].Key;
                             var referenceVariable = $"${{{otherConfigKey}}}";
diff --git a/test/NLog.Extensions.Logging.Tests/NLogLoggingConfigurationTests.cs b/test/NLog.Extensions.Logging.Tests/NLogLoggingConfigurationTests.cs
@@ -201,6 +201,7 @@ public void LoadVariablesDependentConfig()
             memoryConfig["NLog:Targets:file:fileName"] = "${var_file}";
             memoryConfig["NLog:Variables:var_folder"] = "hello";
             memoryConfig["NLog:Variables:var_file"] = "${var_folder}/world.txt";
+            memoryConfig["NLog:Variables:var_logpath"] = "${var_file}";
 
             var logConfig = CreateNLogLoggingConfigurationWithNLogSection(memoryConfig);
 

Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,7 @@ private IEnumerable<IConfigurationSection> GetVariablesChildren(IConfigurationSe`
`349`	`349`	`continue;`
`350`	`350`
`351`	`351`	`var independentVariable = true;`
`352`		`- for (int j = i - 1; j >= 0; j--)`
	`352`	`+ for (int j = sortVariables.Count - 1; j >= 0; j--)`
`353`	`353`	`{`
`354`	`354`	`var otherConfigKey = sortVariables[j].Key;`
`355`	`355`	`var referenceVariable = $"${{{otherConfigKey}}}";`