Fallback to Microsoft Logging Formatter when mixing positional with structured (test coverage) (#757)

snakefoot · web-flow · commit 6a377ff8ad48 · 2024-08-08T17:52:53.000+02:00
diff --git a/test/NLog.Extensions.Logging.Tests/LoggerTests.cs b/test/NLog.Extensions.Logging.Tests/LoggerTests.cs
@@ -220,7 +220,7 @@ public void TestInvalidFormatString()
         [Fact]
         public void TestInvalidFormatString2()
         {
-            var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = true });
+            var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = false });
             var ex = Assert.Throws<AggregateException>(() => runner.Logger.LogDebug("{0}{1}", "Test"));
             Assert.IsType<FormatException>(ex.InnerException);
         }
@@ -236,7 +236,7 @@ public void TestInvalidMixFormatString()
         [Fact]
         public void TestInvalidMixFormatString2()
         {
-            var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = true });
+            var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = false });
             runner.Logger.LogDebug("{0}{Mix}", "Mix", "Test");
             Assert.Equal("NLog.Extensions.Logging.Tests.LoggerTests.Runner|DEBUG|MixTest|0=Mix, Mix=Test", runner.LastTargetMessage);
         }

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ public void TestInvalidFormatString()`
`220`	`220`	`[Fact]`
`221`	`221`	`public void TestInvalidFormatString2()`
`222`	`222`	`{`
`223`		`- var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = true });`
	`223`	`+ var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = false });`
`224`	`224`	`var ex = Assert.Throws<AggregateException>(() => runner.Logger.LogDebug("{0}{1}", "Test"));`
`225`	`225`	`Assert.IsType<FormatException>(ex.InnerException);`
`226`	`226`	`}`
`@@ -236,7 +236,7 @@ public void TestInvalidMixFormatString()`
`236`	`236`	`[Fact]`
`237`	`237`	`public void TestInvalidMixFormatString2()`
`238`	`238`	`{`
`239`		`- var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = true });`
	`239`	`+ var runner = GetRunner<Runner>(new NLogProviderOptions { CaptureMessageTemplates = false });`
`240`	`240`	`runner.Logger.LogDebug("{0}{Mix}", "Mix", "Test");`
`241`	`241`	`Assert.Equal("NLog.Extensions.Logging.Tests.LoggerTests.Runner\|DEBUG\|MixTest\|0=Mix, Mix=Test", runner.LastTargetMessage);`
`242`	`242`	`}`