8000 Simplify `RuleSet::addRule()` · Issue #1015 · MyIntervals/PHP-CSS-Parser · GitHub

Simplify `RuleSet::addRule()` #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

oliverklee opened this issue Feb 27, 2025 · 0 comments

Labels

cleanup

Milestone

9.0.0: Drop suppo...

Contributor

oliverklee commented

From #1004 (comment):

The local $rulesCount is probably unnecessary here, since count is atomic (!== [] might be possible if the type of $rules can be guaranteed to be an array), and end() could be used to access the last element. But that's beyond the scope of this PR.

The text was updated successfully, but these errors were encountered:

oliverklee added the cleanup label

oliverklee added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone

oliverklee mentioned this issue

[CLEANUP] Avoid Hungarian notation in RuleSet #1004

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0