Bugfix/modify document coordinator (arangodb#3266)

fceller · web-flow · commit 111c826026f5 · 2017-09-15T22:49:20.000+02:00
* Fixed ModifyDocument on coordinator. It uses the internally optimized function to extract _key values, which fails on Compact objects

* do not crash server when passing invalid document key type
diff --git a/arangod/Cluster/ClusterMethods.cpp b/arangod/Cluster/ClusterMethods.cpp
@@ -2164,9 +2164,12 @@ int modifyDocumentOnCoordinator(
         TRI_ASSERT(it.second.size() == 1);
         body = std::make_shared<std::string>(slice.toJson());
 
-        TRI_ASSERT(slice.get(StaticStrings::KeyString).isString());
+        auto keySlice = slice.get(StaticStrings::KeyString);
+        if (!keySlice.isString()) {
+          return TRI_ERROR_ARANGO_DOCUMENT_KEY_BAD;
+        }
 
-        StringRef keyStr(slice.get(StaticStrings::KeyString));
+        StringRef keyStr(keySlice);
         // We send to single endpoint
         requests.emplace_back(
             "shard:" + it.first, reqType,
