Fix issue when enumerating commits

nulltoken · nulltoken · commit c0013852416b · 2011-06-26T21:12:38.000+02:00
When not explicitly set, the "Since" boundary should be "HEAD".
diff --git a/LibGit2Sharp.Tests/CommitFixture.cs b/LibGit2Sharp.Tests/CommitFixture.cs
@@ -174,10 +174,22 @@ public void CanEnumerateUsingTwoHeadsAsBoundaries()
         {
             using (var repo = new Repository(Constants.BareTestRepoPath))
             {
-                var commits = repo.Commits.QueryBy(new Filter { Since = "refs/heads/br2", Until = "refs/heads/packed-test" });
+                var commits = repo.Commits.QueryBy(new Filter { Since = "HEAD", Until = "refs/heads/br2" });
 
                 IEnumerable<string> abbrevShas = commits.Select(c => c.Id.ToString(7)).ToArray();
-                CollectionAssert.AreEquivalent(new[] { "a4a7dce", "c47800c", "9fd738e" }, abbrevShas);
+                CollectionAssert.AreEquivalent(new[] { "4c062a6", "be3563a" }, abbrevShas);
+            }
+        }
+
+        [Test]
+        public void CanEnumerateUsingOneHeadAsBoundaries()
+        {
+            using (var repo = new Repository(Constants.BareTestRepoPath))
+            {
+                var commits = repo.Commits.QueryBy(new Filter { Until = "refs/heads/br2" });
+
+                IEnumerable<string> abbrevShas = commits.Select(c => c.Id.ToString(7)).ToArray();
+                CollectionAssert.AreEquivalent(new[] { "4c062a6", "be3563a" }, abbrevShas);
             }
         }
 
@@ -192,7 +204,7 @@ public void CanEnumerateUsingTwoAbbreviatedShasAsBoundaries()
                 CollectionAssert.AreEquivalent(new[] { "a4a7dce", "c47800c", "9fd738e" }, abbrevShas);
             }
         }
-
+        
         [Test]
         public void CanLookupCommitGeneric()
         {
diff --git a/LibGit2Sharp/Filter.cs b/LibGit2Sharp/Filter.cs
@@ -11,6 +11,7 @@ public class Filter
         public Filter()
         {
             SortBy = GitSortOptions.Time;
+            Since = "HEAD";
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -174,10 +174,22 @@ public void CanEnumerateUsingTwoHeadsAsBoundaries()`
`174`	`174`	`{`
`175`	`175`	`using (var repo = new Repository(Constants.BareTestRepoPath))`
`176`	`176`	`{`
`177`		`- var commits = repo.Commits.QueryBy(new Filter { Since = "refs/heads/br2", Until = "refs/heads/packed-test" });`
	`177`	`+ var commits = repo.Commits.QueryBy(new Filter { Since = "HEAD", Until = "refs/heads/br2" });`
`178`	`178`
`179`	`179`	`IEnumerable<string> abbrevShas = commits.Select(c => c.Id.ToString(7)).ToArray();`
`180`		`- CollectionAssert.AreEquivalent(new[] { "a4a7dce", "c47800c", "9fd738e" }, abbrevShas);`
	`180`	`+ CollectionAssert.AreEquivalent(new[] { "4c062a6", "be3563a" }, abbrevShas);`
	`181`	`+ }`
	`182`	`+ }`
	`183`	`+`
	`184`	`+ [Test]`
	`185`	`+ public void CanEnumerateUsingOneHeadAsBoundaries()`
	`186`	`+ {`
	`187`	`+ using (var repo = new Repository(Constants.BareTestRepoPath))`
	`188`	`+ {`
	`189`	`+ var commits = repo.Commits.QueryBy(new Filter { Until = "refs/heads/br2" });`
	`190`	`+`
	`191`	`+ IEnumerable<string> abbrevShas = commits.Select(c => c.Id.ToString(7)).ToArray();`
	`192`	`+ CollectionAssert.AreEquivalent(new[] { "4c062a6", "be3563a" }, abbrevShas);`
`181`	`193`	`}`
`182`	`194`	`}`
`183`	`195`
`@@ -192,7 +204,7 @@ public void CanEnumerateUsingTwoAbbreviatedShasAsBoundaries()`
`192`	`204`	`CollectionAssert.AreEquivalent(new[] { "a4a7dce", "c47800c", "9fd738e" }, abbrevShas);`
`193`	`205`	`}`
`194`	`206`	`}`
`195`		`-`
	`207`	`+`
`196`	`208`	`[Test]`
`197`	`209`	`public void CanLookupCommitGeneric()`
`198`	`210`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ public class Filter`
`11`	`11`	`public Filter()`
`12`	`12`	`{`
`13`	`13`	`SortBy = GitSortOptions.Time;`
	`14`	`+ Since = "HEAD";`
`14`	`15`	`}`
`15`	`16`
`16`	`17`	`/// <summary>`