Replace managed version of lightweight tag creation with native libgit2 implementation

nulltoken · nulltoken · commit 822f6c14f24e · 2011-07-14T16:13:17.000+02:00
diff --git a/LibGit2Sharp/Core/NativeMethods.cs b/LibGit2Sharp/Core/NativeMethods.cs
@@ -189,6 +189,9 @@ public static extern int git_repository_discover(StringBuilder repository_path,
         [DllImport(libgit2)]
         public static extern int git_tag_create(out GitOid oid, RepositorySafeHandle repo, string name, IntPtr target, GitSignature signature, string message, bool force);
 
+        [DllImport(libgit2)]
+        public static extern int git_tag_create_lightweight(out GitOid oid, RepositorySafeHandle repo, string name, IntPtr target, bool force);
+
         [DllImport(libgit2)]
         public static extern int git_tag_delete(RepositorySafeHandle repo, string tagName);
 
diff --git a/LibGit2Sharp/TagCollection.cs b/LibGit2Sharp/TagCollection.cs
@@ -99,11 +99,19 @@ public Tag Create(string name, string target, Signature tagger, string message,
         /// <returns></returns>
         public Tag Create(string name, string target, bool allowOverwrite = false)
         {
+            Ensure.ArgumentNotNullOrEmptyString(name, "name");
             Ensure.ArgumentNotNullOrEmptyString(target, "target");
 
             GitObject objectToTag = RetrieveObjectToTag(target);
 
-            repo.Refs.Create(NormalizeToCanonicalName(name), objectToTag.Id.Sha, allowOverwrite);   //TODO: To be replaced by native libgit2 git_tag_create_lightweight() when available.
+            int res;
+            using (var objectPtr = new ObjectSafeWrapper(objectToTag.Id, repo))
+            {
+                GitOid oid;
+                res = NativeMethods.git_tag_create_lightweight(out oid, repo.Handle, name, objectPtr.ObjectPtr, allowOverwrite);
+            }
+
+            Ensure.Success(res);
 
             return this[name];
         }
