Use Trace.WriteLine when directories cannot be cleaned (in tests)

yorah · nulltoken · commit 81d1490e1d56 · 2013-02-21T20:06:05.000+01:00
We were previously raising an exception, which meant that there was no way to know if the test was successful or not.
diff --git a/LibGit2Sharp.Tests/TestHelpers/DirectoryHelper.cs b/LibGit2Sharp.Tests/TestHelpers/DirectoryHelper.cs
@@ -61,14 +61,14 @@ public static void DeleteDirectory(string directoryPath)
             {
                 Directory.Delete(directoryPath, false);
             } 
-            catch (IOException ex)
+            catch (IOException)
             {
-                throw new IOException(string.Format("{0}The directory '{1}' could not be deleted!" +
+                Trace.WriteLine(string.Format("{0}The directory '{1}' could not be deleted!" +
                                                     "{0}Most of the time, this is due to an external process accessing the files in the temporary repositories created during the test runs, and keeping a handle on the directory, thus preventing the deletion of those files." +
                                                     "{0}Known and common causes include:" +
                                                     "{0}- Windows Search Indexer (go to the Indexing Options, in the Windows Control Panel, and exclude the bin folder of LibGit2Sharp.Tests)" +
                                                     "{0}- Antivirus (exclude the bin folder of LibGit2Sharp.Tests from the paths scanned by your real-time antivirus){0}", 
-                    Environment.NewLine, Path.GetFullPath(directoryPath)), ex);
+                    Environment.NewLine, Path.GetFullPath(directoryPath)));
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -61,14 +61,14 @@ public static void DeleteDirectory(string directoryPath)`
`61`	`61`	`{`
`62`	`62`	`Directory.Delete(directoryPath, false);`
`63`	`63`	`}`
`64`		`- catch (IOException ex)`
	`64`	`+ catch (IOException)`
`65`	`65`	`{`
`66`		`- throw new IOException(string.Format("{0}The directory '{1}' could not be deleted!" +`
	`66`	`+ Trace.WriteLine(string.Format("{0}The directory '{1}' could not be deleted!" +`
`67`	`67`	`"{0}Most of the time, this is due to an external process accessing the files in the temporary repositories created during the test runs, and keeping a handle on the directory, thus preventing the deletion of those files." +`
`68`	`68`	`"{0}Known and common causes include:" +`
`69`	`69`	`"{0}- Windows Search Indexer (go to the Indexing Options, in the Windows Control Panel, and exclude the bin folder of LibGit2Sharp.Tests)" +`
`70`	`70`	`"{0}- Antivirus (exclude the bin folder of LibGit2Sharp.Tests from the paths scanned by your real-time antivirus){0}",`
`71`		`- Environment.NewLine, Path.GetFullPath(directoryPath)), ex);`
	`71`	`+ Environment.NewLine, Path.GetFullPath(directoryPath)));`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`	`}`