Get debug settings from user preference and send it to debuggee#135
Merged
Get debug settings from user preference and send it to debuggee#135
Conversation
2. get debug settings from user settings and send it to debuggee
src/configurationProvider.ts
Outdated
| } | ||
|
|
||
| interface IDebugSettings { | ||
| show_hex?: boolean; |
Contributor
There was a problem hiding this comment.
Use Camel to keep name convention consistent.
src/configurationProvider.ts
Outdated
|
|
||
| function collectDebugSettings(): IDebugSettings { | ||
| const settings: IDebugSettings = {}; | ||
| if (vscode.workspace.getConfiguration().get("java.debug.settings.showHex")) { |
Contributor
There was a problem hiding this comment.
Cannot set the value to false. no need to if.
| }, | ||
| "java.debug.settings.showHex": { | ||
| "type": "boolean", | ||
| "default": false |
Contributor
There was a problem hiding this comment.
add description here.
testforstephen
previously approved these changes
Nov 8, 2017
akaroml
requested changes
Nov 9, 2017
README.md
Outdated
| ### User Settings | ||
|
|
||
| - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`. | ||
| - `java.debug.settings.showHex`: whether or not the number should be displayed as hex format in variable view, defaults to `false`. |
README.md
Outdated
|
|
||
| - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`. | ||
| - `java.debug.settings.showHex`: whether or not the number should be displayed as hex format in variable view, defaults to `false`. | ||
| - `java.debug.settings.showStaticVariables`: whether or not the static variables will be displayed in variable view, defaults to `true`. |
Member
There was a problem hiding this comment.
show static variables in "Variables" viewlet
README.md
Outdated
| - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`. | ||
| - `java.debug.settings.showHex`: whether or not the number should be displayed as hex format in variable view, defaults to `false`. | ||
| - `java.debug.settings.showStaticVariables`: whether or not the static variables will be displayed in variable view, defaults to `true`. | ||
| - `java.debug.settings.showQualifiedNames`: whether or not the class name should be displayed using the fully qualified class name, defaults to `false`. |
Member
There was a problem hiding this comment.
show fully qualified class names
package.json
Outdated
| }, | ||
| "java.debug.settings.showHex": { | ||
| "type": "boolean", | ||
| "description" : "whether or not the number should be displayed as hex format in variable view", |
Member
There was a problem hiding this comment.
Please change the descriptions accordingly.
akaroml
requested changes
Nov 9, 2017
README.md
Outdated
| ### User Settings | ||
|
|
||
| - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`. | ||
| - `java.debug.settings.showHex`: show the number in hex format in variable view, defaults to `false`. |
Member
There was a problem hiding this comment.
show numbers in hex format in "Variables" viewlet, de...
README.md
Outdated
| - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`. | ||
| - `java.debug.settings.showHex`: show the number in hex format in variable view, defaults to `false`. | ||
| - `java.debug.settings.showStaticVariables`: show the static variables in variable view, defaults to `true`. | ||
| - `java.debug.settings.showQualifiedNames`: show the fully qualified class name in variable view, defaults to `false`. |
akaroml
previously approved these changes
Nov 9, 2017
README.md
Outdated
| - `java.debug.logLevel`: minimum level of debugger logs that are sent to VS Code, defaults to `warn`. | ||
| 8000 - `java.debug.settings.showHex`: show numbers in hex format in "Variables" viewlet, defaults to `false`. | ||
| - `java.debug.settings.showStaticVariables`: show static variables in "Variables" viewlet, defaults to `true`. | ||
| - `java.debug.settings.showQualifiedNames`: show the fully qualified class names in "Variables" viewlet, defaults to `false`. |
akaroml
approved these changes
Nov 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.