fix: implementing suggested changes

mf2199 · mf2199 · commit 41abaebb6f2e · 2020-10-25T12:45:27.000-04:00
diff --git a/google/cloud/spanner_dbapi/connection.py b/google/cloud/spanner_dbapi/connection.py
@@ -55,7 +55,8 @@ def autocommit(self):
 
     @autocommit.setter
     def autocommit(self, value):
-        """Change this connection autocommit mode.
+        """Change this connection autocommit mode. Setting this value to True
+        while a transaction is active will commit the current transaction.
 
         :type value: bool
         :param value: New autocommit mode state.
@@ -152,15 +153,22 @@ def close(self):
         self.is_closed = True
 
     def commit(self):
-        """Commits any pending transaction to the database."""
+        """Commits any pending transaction to the database.
+
+        This method is non-operational in autocommit mode.
+        """
         if self._autocommit:
             warnings.warn(AUTOCOMMIT_MODE_WARNING, UserWarning, stacklevel=2)
         elif self._transaction:
             self._transaction.commit()
             self._release_session()
 
     def rollback(self):
-        """Rollback all the pending transactions."""
+        """Rolls back any pending transaction.
+
+        This is a no-op if there is no active transaction or if the connection
+        is in autocommit mode.
+        """
         if self._autocommit:
             warnings.warn(AUTOCOMMIT_MODE_WARNING, UserWarning, stacklevel=2)
         elif self._transaction:
