don't fiddle with thread structs that were not initialized yet (arangodb#6978)

jsteemann · web-flow · commit b23ba07c1b42 · 2018-10-22T16:47:23.000+02:00
diff --git a/lib/Basics/Thread.cpp b/lib/Basics/Thread.cpp
@@ -158,6 +158,7 @@ std::string Thread::stringify(ThreadState state) {
 
 Thread::Thread(std::string const& name, bool deleteOnExit)
     : _deleteOnExit(deleteOnExit),
+      _threadStructInitialized(false),
       _name(name),
       _thread(),
       _threadNumber(0),
@@ -181,12 +182,14 @@ Thread::~Thread() {
       << "delete(" << _name << "), state: " << stringify(state);
 
   if (state == ThreadState::STOPPED) {
-    if (TRI_IsSelfThread(&_thread)) {
-      // we must ignore any errors here, but TRI_DetachThread will log them
-      TRI_DetachThread(&_thread);
-    } else {
-      // we must ignore any errors here, but TRI_JoinThread will log them
-      TRI_JoinThread(&_thread);
+    if (_threadStructInitialized) {
+      if (TRI_IsSelfThread(&_thread)) {
+        // we must ignore any errors here, but TRI_DetachThread will log them
+        TRI_DetachThread(&_thread);
+      } else {
+        // we must ignore any errors here, but TRI_JoinThread will log them
+        TRI_JoinThread(&_thread);
+      }
     }
 
     _state.store(ThreadState::DETACHED);
@@ -320,6 +323,9 @@ bool Thread::start(ConditionVariable* finishedCondition) {
     return false;
   }
 
+  TRI_ASSERT(!_threadStructInitialized);
+  memset(&_thread, 0, sizeof(thread_t));
+
   bool ok =
       TRI_StartThread(&_thread, &_threadId, _name.c_str(), &startThread, this);
 
@@ -333,6 +339,8 @@ bool Thread::start(ConditionVariable* finishedCondition) {
     cleanupMe();
   }
 
+  _threadStructInitialized = true;
+
   return ok;
 }
 
diff --git a/lib/Basics/Thread.h b/lib/Basics/Thread.h
@@ -212,6 +212,7 @@ class Thread {
 
  private:
   bool const _deleteOnExit;
+  bool _threadStructInitialized;
 
   // name of the thread
   std::string const _name;
