8000 feat(v8/node): Remove LocalVariables class integration (#10558) · MFoster/sentry-javascript@ca6010b · GitHub
[go: up one dir, main page]
Skip to content

Commit ca6010b

Browse files
AbhiPrasadAbhiPrasad
authored
feat(v8/node): Remove LocalVariables class integration (getsentry#10558)
Works toward getsentry#8844 in a more incremental way.
1 parent 9307308 commit ca6010b

File tree

6 files changed

+4
-31
lines changed

6 files changed

+4
-31
lines changed

‎dev-packages/e2e-tests/test-applications/create-next-app/sentry.server.config.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,7 @@ Sentry.init({
1515
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
1616
// Adjust this value in production, or use tracesSampler for greater control
1717
tracesSampleRate: 1.0,
18-
// ...
19-
// Note: if you want to override the automatic release value, do not set a
20-
// `release` value here - use the environment variable `SENTRY_RELEASE`, so
21-
// that it will also get attached to your source maps
22-
23-
integrations: [new Sentry.Integrations.LocalVariables()],
18+
integrations: [Sentry.localVariablesIntegration()],
2419
});
2520

2621
Sentry.addEventProcessor(event => {

‎dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables-memory-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Sentry.init({
77
includeLocalVariables: true,
88
transport: loggingTransport,
99
// Stop the rate limiting from kicking in
10-
integrations: [new Sentry.Integrations.LocalVariables({ maxExceptionsPerSecond: 10000000 })],
10+
integrations: [Sentry.localVariablesIntegration({ maxExceptionsPerSecond: 10000000 })],
1111
});
1212

1313
class Some {

‎packages/bun/src/sdk.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ export const defaultIntegrations = [
3737
// new NodeIntegrations.OnUnhandledRejection(),
3838
// Event Info
3939
contextLinesIntegration(),
40-
// new NodeIntegrations.LocalVariables(), # does't work with Bun
4140
nodeContextIntegration(),
4241
modulesIntegration(),
4342
// Bun Specific

‎packages/node-experimental/src/integrations/index.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,10 @@ const {
88
ContextLines,
99
Context,
1010
RequestData,
11-
LocalVariables,
1211
// eslint-disable-next-line deprecation/deprecation
1312
} = NodeIntegrations;
1413

15-
export {
16-
Console,
17-
OnUncaughtException,
18-
OnUnhandledRejection,
19-
Modules,
20-
ContextLines,
21-
Context,
22-
RequestData,
23-
LocalVariables,
24-
};
14+
export { Console, OnUncaughtException, OnUnhandledRejection, Modules, ContextLines, Context, RequestData };
2515

2616
/* eslint-disable deprecation/deprecation */
2717
export { Express } from './express';

‎packages/node/src/integrations/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export { Modules } from './modules';
77
export { ContextLines } from './contextlines';
88
export { Context } from './context';
99
export { RequestData } from '@sentry/core';
10-
export { LocalVariables } from './local-variables';
1110
export { Undici } from './undici';
1211
export { Spotlight } from './spotlight';
1312
export { Anr } from './anr';

‎packages/node/src/integrations/local-variables/index.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,3 @@
1-
import { LocalVariablesSync, localVariablesSyncIntegration } from './local-variables-sync';
2-
3-
/**
4-
* Adds local variables to exception frames.
5-
*
6-
* @deprecated Use `localVariablesIntegration()` instead.
7-
*/
8-
// eslint-disable-next-line deprecation/deprecation
9-
export const LocalVariables = LocalVariablesSync;
10-
// eslint-disable-next-line deprecation/deprecation
11-
export type LocalVariables = LocalVariablesSync;
1+
import { localVariablesSyncIntegration } from './local-variables-sync';
122

133
export const localVariablesIntegration = localVariablesSyncIntegration;

0 commit comments

Comments
 (0)
0