Fix PHP Fatal Error deleteDirectoryRecursive function in MinifyApplicationCommand

LunashaGit · LunashaGit · commit 2959bc523cc3 · 2024-02-06T18:39:56.000+01:00
diff --git a/src/Commands/MinifyApplicationCommand.php b/src/Commands/MinifyApplicationCommand.php
@@ -86,7 +86,7 @@ protected function removeIgnoredFilesAndFolders(string $appPath): void
         }
     }
 
-    private function deleteDirectoryRecursive(string $directory): void
+    private function deleteDirectoryRecursive(string $directory): bool
     {
         if (! file_exists($directory)) {
             return true;
@@ -106,6 +106,6 @@ private function deleteDirectoryRecursive(string $directory): void
             }
         }
 
-        rmdir($directory);
+        return rmdir($directory);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ protected function removeIgnoredFilesAndFolders(string $appPath): void`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`- private function deleteDirectoryRecursive(string $directory): void`
	`89`	`+ private function deleteDirectoryRecursive(string $directory): bool`
`90`	`90`	`{`
`91`	`91`	`if (! file_exists($directory)) {`
`92`	`92`	`return true;`
`@@ -106,6 +106,6 @@ private function deleteDirectoryRecursive(string $directory): void`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`
`109`		`- rmdir($directory);`
	`109`	`+ return rmdir($directory);`
`110`	`110`	`}`
`111`	`111`	`}`