fix: leetcode.hideSolved not working (LeetCode-OpenSource#319)

jdneo · web-flow · commit f656f8592cb2 · 2019-05-15T19:11:02.000+08:00
diff --git a/src/explorer/explorerNodeManager.ts b/src/explorer/explorerNodeManager.ts
@@ -4,7 +4,8 @@
 import * as _ from "lodash";
 import { Disposable } from "vscode";
 import * as list from "../commands/list";
-import { Category, defaultProblem } from "../shared";
+import { Category, defaultProblem, ProblemState } from "../shared";
+import { shouldHideSolvedProblem } from "../utils/settingUtils";
 import { LeetCodeNode } from "./LeetCodeNode";
 
 class ExplorerNodeManager implements Disposable {
@@ -14,7 +15,11 @@ class ExplorerNodeManager implements Disposable {
 
     public async refreshCache(): Promise<void> {
         this.dispose();
+        const shouldHideSolved: boolean = shouldHideSolvedProblem();
         for (const problem of await list.listProblems()) {
+            if (shouldHideSolved && problem.state === ProblemState.AC) {
+                continue;
+            }
             this.explorerNodeMap.set(problem.id, new LeetCodeNode(problem));
             for (const company of problem.companies) {
                 this.companySet.add(company);
diff --git a/src/utils/settingUtils.ts b/src/utils/settingUtils.ts
@@ -0,0 +1,12 @@
+// Copyright (c) jdneo. All rights reserved.
+// Licensed under the MIT license.
+
+import { workspace, WorkspaceConfiguration } from "vscode";
+
+export function getWorkspaceConfiguration(): WorkspaceConfiguration {
+    return workspace.getConfiguration("leetcode");
+}
+
+export function shouldHideSolvedProblem(): boolean {
+    return getWorkspaceConfiguration().get<boolean>("hideSolved", false);
+}
diff --git a/src/utils/uiUtils.ts b/src/utils/uiUtils.ts
@@ -4,7 +4,7 @@
 import * as vscode from "vscode";
 import { getLeetCodeEndpoint } from "../commands/plugin";
 import { leetCodeChannel } from "../leetCodeChannel";
-import { getWorkspaceConfiguration } from "./workspaceUtils";
+import { getWorkspaceConfiguration } from "./settingUtils";
 
 export namespace DialogOptions {
     export const open: vscode.MessageItem = { title: "Open" };
diff --git a/src/utils/workspaceUtils.ts b/src/utils/workspaceUtils.ts
@@ -40,7 +40,3 @@ export async function getActiveFilePath(uri?: vscode.Uri): Promise<string | unde
     }
     return wsl.useWsl() ? wsl.toWslPath(textEditor.document.uri.fsPath) : textEditor.document.uri.fsPath;
 }
-
-export function getWorkspaceConfiguration(): vscode.WorkspaceConfiguration {
-    return vscode.workspace.getConfiguration("leetcode");
-}

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,3 @@ export async function getActiveFilePath(uri?: vscode.Uri): Promise<string \| unde`
`40`	`40`	`}`
`41`	`41`	`return wsl.useWsl() ? wsl.toWslPath(textEditor.document.uri.fsPath) : textEditor.document.uri.fsPath;`
`42`	`42`	`}`
`43`		`-`
`44`		`-export function getWorkspaceConfiguration(): vscode.WorkspaceConfiguration {`
`45`		`- return vscode.workspace.getConfiguration("leetcode");`
`46`		`-}`