Set AP IP address on ::beginAP

earlephilhower · earlephilhower · commit afbba6854973 · 2024-01-02T18:20:25.000-08:00
The Arduino WiFi normalization ended up calling the underlying LWIP ::config after the AP was begin, resulting in a failure to set the IP configuration of the AP. Move the _wifi.begin() call to after the IP configuration is set. Fixes earlephilhower#1989
diff --git a/libraries/WiFi/src/WiFiClass.cpp b/libraries/WiFi/src/WiFiClass.cpp
@@ -142,10 +142,6 @@ uint8_t WiFiClass::beginAP(const char *ssid, const char* passphrase) {
     _wifi.setTimeout(_timeout);
     _wifi.setAP();
     _apMode = true;
-    if (!_wifi.begin()) {
-        return WL_IDLE_STATUS;
-    }
-    noLowPowerMode();
     IPAddress gw = _wifi.gatewayIP();
     if (!gw.isSet()) {
         gw = IPAddress(192, 168, 42, 1);
@@ -155,6 +151,10 @@ uint8_t WiFiClass::beginAP(const char *ssid, const char* passphrase) {
         mask = IPAddress(255, 255, 255, 0);
     }
     config(gw);
+    if (!_wifi.begin()) {
+        return WL_IDLE_STATUS;
+    }
+    noLowPowerMode();
     _dhcpServer = (dhcp_server_t *)malloc(sizeof(dhcp_server_t));
     if (!_dhcpServer) {
         // OOM
