Updating tests to work on Windows and Mac, Py2 and Py3. I'm manually managing temp files right now, but we may want to modify our Workbook and Datasource classes to accept all File-Like objects in the future so I don't have to do this filename sillyness. Still, this works for now and is cross platform

t8y8 · t8y8 · commit cc9437130e90 · 2016-05-11T16:24:12.000-07:00
diff --git a/Document API/test.py b/Document API/test.py
@@ -1,6 +1,6 @@
 import unittest
-import tempfile
-
+import io
+import os
 import xml.etree.ElementTree as ET
 
 from tableaudocumentapi import Workbook, Datasource, Connection
@@ -61,10 +61,14 @@ def test_can_write_attributes_to_connection(self):
 class DatasourceModelTests(unittest.TestCase):
 
     def setUp(self):
-        self.tds_file = tempfile.NamedTemporaryFile(suffix='.tds')
+        self.tds_file = io.FileIO('test.tds', 'w')
         self.tds_file.write(TABLEAU_93_TDS.encode('utf8'))
         self.tds_file.seek(0)
 
+    def tearDown(self):
+        self.tds_file.close()
+        os.unlink(self.tds_file.name)
+
     def test_can_extract_datasource_from_file(self):
         ds = Datasource.from_file(self.tds_file.name)
         self.assertEqual(ds.name, 'sqlserver.17u3bqc16tjtxn14e2hxh19tyvpo')
@@ -78,10 +82,14 @@ def test_can_extract_connection(self):
 class WorkbookModelTests(unittest.TestCase):
 
     def setUp(self):
-        self.workbook_file = tempfile.NamedTemporaryFile(suffix='.twb')
+        self.workbook_file = io.FileIO('test.twb', 'w')
         self.workbook_file.write(TABLEAU_93_WORKBOOK.encode('utf8'))
         self.workbook_file.seek(0)
 
+    def tearDown(self):
+        self.workbook_file.close()
+        os.unlink(self.workbook_file.name)
+
     def test_can_extract_datasource(self):
         wb = Workbook(self.workbook_file.name)
         self.assertEqual(len(wb.datasources), 1)
