8000 Merge pull request #19 from EBoisseauSierra/rewording-instructions · Laguna1/javascript-exercises@29bd246 · GitHub
[go: up one dir, main page]
Skip to content

Commit 29bd246

Browse files
codyloydcodyloyd
authored
Merge pull request TheOdinProject#19 from EBoisseauSierra/rewording-instructions
Rewording instructions
2 parents b99fe58 + 00407bd commit 29bd246

33 files changed

+57
-50
lines changed

‎caesar/caesar.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var caesar = function() {
1+
const caesar = function() {
22

33
}
44

‎caesar/caesar.spec.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var caesar = require('./caesar')
1+
const caesar = require('./caesar')
22

33
describe('caesar', function() {
44
it('works with single letters', function() {
@@ -19,4 +19,7 @@ describe('caesar', function() {
1919
xit('works with large shift factors', function() {
2020
expect(caesar('Hello, World!', 75)).toEqual('Ebiil, Tloia!');
2121
});
22+
xit('works with large negative shift factors', function() {
23+
expect(caesar('Hello, World!', -29)).toEqual('Ebiil, Tloia!');
24+
});
2225
});

‎calculator/calculator.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var calculator = require ('./calculator.js');
1+
const calculator = require ('./calculator.js');
22

33
describe('add', function() {
44
it('adds 0 and 0', function() {

‎fibonacci/fibonacci.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var fibonacci = function() {
1+
const fibonacci = function() {
22

33
}
44

‎fibonacci/fibonacci.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var fibonacci = require('./fibonacci')
1+
const fibonacci = require('./fibonacci')
22

33
describe('fibonacci', function() {
44
it('works', function() {

‎generator-exercise/generators/app/templates/title.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var <%= title %> = function() {
1+
let <%= title %> = function() {
22

33
}
44

‎generator-exercise/generators/app/templates/title.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var <%= title %> = require('./<%=title%>')
1+
let <%= title %> = require('./<%=title%>')
22

33
describe('<%=title%>', function() {
44
it('EDITME', function() {

‎helloWorld/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This setup should be the same for all of the exercises. The plain javascript fi
1010

1111
Let's look at the spec file first:
1212
```javascript
13-
var helloWorld = require('./helloWorld');
13+
const helloWorld = require('./helloWorld');
1414

1515
describe('Hello World', function() {
1616
it('says hello world', function() {
@@ -26,7 +26,7 @@ For now you do not need to worry about how to write tests, but you should try to
2626

2727
so let's look at the javascript file:
2828
```javascript
29-
var helloWorld = function() {
29+
const helloWorld = function() {
3030
return ''
3131
}
3232

@@ -40,7 +40,7 @@ Just to make sure, in case you're confused at this point, the test is telling yo
4040

4141
this is what the final function should look like:
4242
```javascript
43-
var helloWorld = function() {
43+
const helloWorld = function() {
4444
return 'Hello, World!'
4545
}
4646

‎helloWorld/helloWorld.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
var helloWorld = function() {
1+
const helloWorld = function() {
22
return ''
33
}
44

5-
module.exports = helloWorld
5+
module.exports = helloWorld

‎helloWorld/helloWorld.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
var helloWorld = require('./helloWorld');
1+
const helloWorld = require('./helloWorld');
22

33
describe('Hello World', function() {
44
it('says hello world', function() {
55
expect(helloWorld()).toEqual('Hello, World!');
66
});
7-
});
7+
});

0 commit comments

Comments
 (0)
0