8000 Http\Client\HttpClient Deprecation · Issue #1119 · KnpLabs/php-github-api · GitHub
[go: up one dir, main page]
Skip to content

Http\Client\HttpClient Deprecation #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Fabricio872 opened this issue Aug 2, 2023 · 2 comments
Closed

Http\Client\HttpClient Deprecation #1119

Fabricio872 opened this issue Aug 2, 2023 · 2 comments

Comments

@Fabricio872
Copy link

The project is using Http\Client\HttpClient which is deprecated since symfony/framework-bundle 6.3 and it is recommended to be replaced with Psr\Http\Client\ClientInterface.
@mbabker
Copy link
mbabker commented Aug 21, 2023

The deprecation in Symfony is that the Http\Client\HttpClient service alias will no longer be created in 7.0 (thanks in part to php-http/httplug#171 which deprecates that interface). To my recollection, there isn't anything in this package that hard requires that interface anymore as everything either uses PSR-17/18 or other HTTPlug objects.

Can you post a stack trace showing how the deprecation is triggered or an example of how your services are configured that would cause this deprecation to be triggered in a Symfony app?

@tacman tacman mentioned this issue Nov 16, 2023
Closed
@acrobat
Copy link
Collaborator
acrobat commented Nov 19, 2023

Closing this issue for now as indeed the deprecation itself is not related to this library. If you still have problems reopen this issue or open a new issue. Thanks.

@acrobat acrobat closed this as completed Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbabker @acrobat @Fabricio872
0