Respect preId in .npmrc for release tags (sindresorhus#547)

dopecodez · web-flow · commit aebd8abb6efc · 2020-07-04T01:28:20.000+08:00
diff --git a/source/release-task-helper.js b/source/release-task-helper.js
@@ -1,18 +1,22 @@
 'use strict';
 const open = require('open');
 const newGithubReleaseUrl = require('new-github-release-url');
-const {getTagVersionPrefix} = require('./util');
+const {getTagVersionPrefix, getPreReleasePrefix} = require('./util');
 const version = require('./version');
 
 module.exports = async (options, pkg) => {
 	const newVersion = version(pkg.version).getNewVersionFrom(options.version);
-	const tag = await getTagVersionPrefix(options) + newVersion;
+	let tag = await getTagVersionPrefix(options) + newVersion;
+	const isPreRelease = version(options.version).isPrerelease();
+	if (isPreRelease) {
+		tag += await getPreReleasePrefix();
+	}
 
 	const url = newGithubReleaseUrl({
 		repoUrl: options.repoUrl,
 		tag,
 		body: options.releaseNotes(tag),
-		isPrerelease: version(options.version).isPrerelease()
+		isPrerelease: isPreRelease
 	});
 
 	await open(url);
diff --git a/source/util.js b/source/util.js
@@ -68,3 +68,27 @@ exports.getTagVersionPrefix = pMemoize(async options => {
 		return 'v';
 	}
 });
+
+exports.getPreReleasePrefix = pMemoize(async options => {
+	ow(options, ow.object.hasKeys('yarn'));
+
+	try {
+		if (options.yarn) {
+			const {stdout} = await execa('yarn', ['config', 'get', 'preId']);
+			if (stdout !== 'undefined') {
+				return stdout;
+			}
+
+			return '';
+		}
+
+		const {stdout} = await execa('npm', ['config', 'get', 'preId']);
+		if (stdout !== 'undefined') {
+			return stdout;
+		}
+
+		return '';
+	} catch (_) {
+		return '';
+	}
+});
diff --git a/test/preid.js b/test/preid.js
@@ -0,0 +1,12 @@
+import test from 'ava';
+import {getPreReleasePrefix} from '../source/util';
+
+test('get preId postfix', async t => {
+	t.is(await getPreReleasePrefix({yarn: false}), '');
+	t.is(await getPreReleasePrefix({yarn: true}), '');
+});
+
+test('no options passed', async t => {
+	await t.throwsAsync(getPreReleasePrefix(), {message: 'Expected `options` to be of type `object` but received type `undefined`'});
+	await t.throwsAsync(getPreReleasePrefix({}), {message: 'Expected object `options` to have keys `["yarn"]`'});
+});
