8000 Bump typescript from 4.3.5 to 4.4.2 · Issue #866 · JamesIves/github-pages-deploy-action · GitHub
[go: up one dir, main page]

Skip to content
Bump typescript from 4.3.5 to 4.4.2 #866
Closed
@JamesIves

Description

@JamesIves

Describe the bug

Tests are failing when Dependabot attempts to upgrade from TypeScript 4.3.5 to 4.4.2.

Reproduction Steps

  • Pull down the branch dependabot/npm_and_yarn/typescript-4.4.2
  • Run yarn install followed by yarn build
  • You'll see a number of type errors caused by some improperly typed tests.

Logs

FAIL __tests__/git.test.ts
  ● Test suite failed to run

    __tests__/git.test.ts:83:16 - error TS2571: Object is of type 'unknown'.

    83         expect(error.message).toBe(
                      ~~~~~
    __tests__/git.test.ts:422:16 - error TS2571: Object is of type 'unknown'.

    422         expect(error.message).toBe(
                       ~~~~~

FAIL __tests__/util.test.ts
  ● Test suite failed to run

    __tests__/util.test.ts:225:16 - error TS2571: Object is of type 'unknown'.

    225         expect(e.message).toMatch(
                       ~
    __tests__/util.test.ts:245:16 - error TS2571: Object is of type 'unknown'.

    245         expect(e.message).toMatch(
                       ~
    __tests__/util.test.ts:265:16 - error TS2571: Object is of type 'unknown'.

    265         expect(e.message).toMatch('Branch is required.')
                       ~
    __tests__/util.test.ts:283:16 - error TS2571: Object is of type 'unknown'.

    283         expect(e.message).toMatch(
                       ~
    __tests__/util.test.ts:304:16 - error TS2571: Object is of type 'unknown'.

    304         expect(e.message).toMatch(
                       ~

FAIL __tests__/worktree.test.ts
  ● Test suite failed to run

    src/worktree.ts:80:9 - error TS2571: Object is of type 'unknown'.

    80         error.message,
               ~~~~~

FAIL __tests__/ssh.test.ts
  ● Test suite failed to run

    __tests__/ssh.test.ts:136:14 - error TS2571: Object is of type 'unknown'.

    136       expect(error.message).toBe(
                     ~~~~~

FAIL __tests__/main.test.ts
  ● Test suite failed to run

    src/lib.ts:55:15 - error TS2571: Object is of type 'unknown'.

    55     setFailed(error.message)
                     ~~~~~

FAIL __tests__/worktree.error.test.ts
  ● Test suite failed to run

    __tests__/worktree.error.test.ts:31:14 - error TS2571: Object is of type 'unknown'.

    31       expect(error.message).toBe(
                    ~~~~~

PASS __tests__/execute.test.ts
  execute
    ✓ should be called with the correct arguments when silent mode is enabled (4 ms)
    ✓ should not silence the input when action.silent is false (1 ms)

Failed to collect coverage from /home/runner/work/github-pages-deploy-action/github-pages-deploy-action/src/git.ts
ERROR: src/git.ts:66:9 - error TS2571: Object is of type 'unknown'.

66         error.message,
           ~~~~~
src/git.ts:211:9 - error TS2571: Object is of type 'unknown'.

211         error.message,
            ~~~~~
STACK: 
Failed to collect coverage from /home/runner/work/github-pages-deploy-action/github-pages-deploy-action/src/ssh.ts
ERROR: src/ssh.ts:49:9 - error TS2571: Object is of type 'unknown'.

49         error.message,
           ~~~~~

Expected Behavior

Types should be updated and the build should pass.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 🐝This issue describes a bug.dependenciesPull requests that update a dependency filehacktoberfest🎃 Hacktoberfest related changes.help wanted ❕Extra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0