fix: ValueError should be raised, not returned

vladimir-mencl-eresearch · vladimir-mencl-eresearch · commit 58a7c15e5ee9 · 2022-11-09T00:02:08.000+13:00
Fix an issue where invalid config might lead to an ValueError object
being used as a databasse object, leading to application errors later.

Rather fail fast by properly raising the exception.
diff --git a/src/pyop/storage.py b/src/pyop/storage.py
@@ -93,7 +93,7 @@ def from_uri(cls, db_uri, collection, db_name=None, ttl=None, **kwargs):
                 alg=alg
             )
 
-        return ValueError(f"Invalid DB URI: {db_uri}")
+        raise ValueError(f"Invalid DB URI: {db_uri}")
 
     @classmethod
     def type(cls, db_uri):
@@ -105,7 +105,7 @@ def type(cls, db_uri):
         elif url.scheme == "stateless":
             return "stateless"
 
-        return ValueError(f"Invalid DB URI: {db_uri}")
+        raise ValueError(f"Invalid DB URI: {db_uri}")
 
     @property
     def ttl(self):
