Comparing changes
Open a pull request
- 10 commits
- 8 files changed
- 2 contributors
Commits on Jun 14, 2023
-
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
-
Change AppVeyor to test more versions, no wheels
We already generate wheels in our GitHub Actions via cibuildwheel, so there's no need to generate them in AppVeyor anymore (we used to when we manually generated wheels for different platforms). On the flip side, we can test against more python versions, and only focus on 64-bit builds. Keeping AppVeyor around is still a good thing, as it gives us quick feedback if there's something broken with a build on Windows without the overheads of cibuildwheel. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
-
Add an explicit test for loading the yajl2_c extension (#99)
Following the discussion in #98, add an explicit test that verifies that the yajl2_c extension can be loaded successfully if it was built. If the extension module is not present, the test is skipped. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Commits on Jun 16, 2023
-
Fix compilation with Python 3.12
Python 3.12 finally removed PyUnicode_GET_SIZE, which we were still using unaware of its deprecation. This commit defines a macro that uses PyUnicode_GET_SIZE for Python 2.7, or PyUnicode_GET_LENGTH (the function we should be using) for Python 3. This addresses the original issue reported in #98. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
-
Deal with normalised exceptions correctly
Exceptions retrieved via PyErr_Fetch might be normalised or not. This respectively means that the second argument of PyErr_Fetch will contain the exception object itself (i.e., an instance of StopIteration), or the value that the exception object would contain if actually built (i.e., the result we are interested in). We have always received non-normalised exceptions until now, but we *could* have received normalised ones, so this was a bug that was waiting to happen at some point. More importantly, starting with Python 3.12 exception values returned by PyErr_Fetch and friends are *always* normalised, so the async funcitons of the C backend were not working correctly (because gen->read_func didn't contain a function, but an instance of StopIteration). This commit addresses further problems found while working on #98.
-
Handle case when distutils is no more
Python 3.12 has officially removed distutils from the python standard library. While in practice it still seems to work somehow in local tests, we should be prepared to use setuptool's copy instead. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Commits on Jun 20, 2023
-
Document fixes for Python 3.12
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
-
Add an environment variable to control building yajl2_c
Add a IJSON_BUILD_YAJL2C environment variable to make it possible to override whether yajl2_c is being built. The default is to build it if either yajl2 is found or embedding is enabled. However, the envvar can be used to either force building (i.e. effectively make the build fail if yajl2 is not detected) or disable building it even if yajl2 is installed. The primary use case is to make it possible to disable building the extension for PyPy3 where it is currently known to be broken. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Commits on Jun 22, 2023
-
Document new env variable to control yajl2_c build
This was added in #102, should have documented it in that PR. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.2.1...v3.2.2