fix: remove test command and related code from setup.py
#203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
7a33d40 to
9a8366f
Compare
5 tasks
padamstx
approved these changes
Jul 29, 2024
Contributor
There was a problem hiding this comment.
Looks good, but just had a question to be addressed before merging
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jul 29, 2024
## [3.20.4](v3.20.3...v3.20.4) (2024-07-29) ### Bug Fixes * remove test command and related code from `setup.py` ([#203](#203)) ([bd44dd1](bd44dd1))
|
🎉 This PR is included in version 3.20.4 🎉 The release is available on GitHub release AAD4 Your semantic-release bot 📦🚀 |
pyrooka
added a commit
to IBM/platform-services-python-sdk
that referenced
this pull request
Jul 29, 2024
This commit removes an unused `setuptools` import from the `setup.py` file. More details about the `setuptools` mess can be found in the following PR: IBM/python-sdk-core#203 Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testcommand and related function were deprecated for 5 yearsand it seems the time has come: setuptools maintainers removed it
yesterday and that move has broken a bunch of Python packages
including this. After looking into several documentations and our source
code, I think the right thing to do - instead of making a workaround - is
completely removing it from our
setup.pyfile as it hasn't been used fora long time - correct me if I am wrong here and missed something!!
Some details:
setuptoolsrepo: [BUG] Many packages are no longer installable after test command is removed pypa/setuptools#4519