@@ -26,11 +26,17 @@ Here's the process to make changes to the codebase:
26
26
2 . Review [ open pull requests] ( https://github.com/spdx/tools-python/pulls ) before committing time to a substantial
27
27
revision. Work along similar lines may already be in progress.
28
28
29
- 3 . Create a new branch:
29
+ 3 . Fork the repository as described [ here] ( https://docs.github.com/en/get-started/quickstart/fork-a-repo#forking-a-repository )
30
+ and optionally follow the further steps described to sync your fork and the original repository.
31
+
32
+ 4 . Create a new branch in your fork and set up environment:
30
33
``` sh
31
34
git checkout -b fix-or-improve-something
35
+ python -m venv ./venv
36
+ ./venv/bin/activate
37
+ pip install -e .
32
38
```
33
- 4 . Make some changes and commit them to the branch:
39
+ 5 . Make some changes and commit them to the branch:
34
40
``` sh
35
41
git commit --signoff -m ' description of my changes'
36
42
```
@@ -42,22 +48,22 @@ Here's the process to make changes to the codebase:
42
48
commits: ` git commit -s ` or ` --signoff ` signs a current commit, and ` git rebase --signoff <revision-range> `
43
49
retroactively signs a range of past commits.
44
50
45
- 5 . Test your changes:
51
+ 6 . Test your changes:
46
52
``` sh
47
53
python setup.py test # in the repo root
48
54
```
49
55
You may use other test runners, such as ` pytest ` or ` nose ` at your preference.
50
- 6 . Push the branch to your fork on GitHub:
56
+ 7 . Push the branch to your fork on GitHub:
51
57
``` sh
52
58
git push origin fix-or-improve-something
53
59
```
54
- 7 . Make a pull request on GitHub.
55
- 8 . Continue making more changes and commits on the branch, with ` git commit --signoff ` and ` git push ` .
56
- 9 . When done, write a comment on the PR asking for a code review.
57
- 10 . Some other developer will review your changes and accept your PR. The merge should be done with ` rebase ` , if
60
+ 8 . Make a pull request on GitHub.
61
+ 9 . Continue making more changes and commits on the branch, with ` git commit --signoff ` and ` git push ` .
62
+ 10 . When done, write a comment on the PR asking for a code review.
63
+ 11 . Some other developer will review your changes and accept your PR. The merge should be done with ` rebase ` , if
58
64
possible, or with ` squash ` .
59
- 11 . The temporary branch on GitHub should be deleted (there is a button for deleting it).
60
- 12 . Delete the local branch as well:
65
+ 12 . The temporary branch on GitHub should be deleted (there is a button for deleting it).
66
+ 13 . Delete the local branch as well:
61
67
``` sh
62
68
git checkout master
63
69
git pull -p
0 commit comments