8000 [issue-468] add a step to fork the repository · HarshvMahawar/tools-python@de1e86e · GitHub
[go: up one dir, main page]

Skip to content

Commit de1e86e

Browse files
meretparmintaenzertng
authored andcommitted
[issue-468] add a step to fork the repository
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com> Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
1 parent b132d32 commit de1e86e

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

CONTRIBUTING.md

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,17 @@ Here's the process to make changes to the codebase:
2626
2. Review [open pull requests](https://github.com/spdx/tools-python/pulls) before committing time to a substantial
2727
revision. Work along similar lines may already be in progress.
2828

29-
3. Create a new branch:
29+
3. Fork the repository as described [here](https://docs.github.com/en/get-started/quickstart/fork-a-repo#forking-a-repository)
30+
and optionally follow the further steps described to sync your fork and the original repository.
31+
32+
4. Create a new branch in your fork and set up environment:
3033
```sh
3134
git checkout -b fix-or-improve-something
35+
python -m venv ./venv
36+
./venv/bin/activate
37+
pip install -e .
3238
```
33-
4. Make some changes and commit them to the branch:
39+
5. Make some changes and commit them to the branch:
3440
```sh
3541
git commit --signoff -m 'description of my changes'
3642
```
@@ -42,22 +48,22 @@ Here's the process to make changes to the codebase:
4248
commits: `git commit -s` or `--signoff` signs a current commit, and `git rebase --signoff <revision-range>`
4349
retroactively signs a range of past commits.
4450

45-
5. Test your changes:
51+
6. Test your changes:
4652
```sh
4753
python setup.py test # in the repo root
4854
```
4955
You may use other test runners, such as `pytest` or `nose` at your preference.
50-
6. Push the branch to your fork on GitHub:
56+
7. Push the branch to your fork on GitHub:
5157
```sh
5258
git push origin fix-or-improve-something
5359
```
54-
7. Make a pull request on GitHub.
55-
8. Continue making more changes and commits on the branch, with `git commit --signoff` and `git push`.
56-
9. When done, write a comment on the PR asking for a code review.
57-
10. Some other developer will review your changes and accept your PR. The merge should be done with `rebase`, if
60+
8. Make a pull request on GitHub.
61+
9. Continue making more changes and commits on the branch, with `git commit --signoff` and `git push`.
62+
10. When done, write a comment on the PR asking for a code review.
63+
11. Some other developer will review your changes and accept your PR. The merge should be done with `rebase`, if
5864
possible, or with `squash`.
59-
11. The temporary branch on GitHub should be deleted (there is a button for deleting it).
60-
12. Delete the local branch as well:
65+
12. The temporary branch on GitHub should be deleted (there is a button for deleting it).
66+
13. Delete the local branch as well:
6167
```sh
6268
git checkout master
6369
git pull -p

0 commit comments

Comments
 (0)
0