10000 feat(tracing|core): Remove transaction name change recording (#7197) · HPLai/sentry-javascript@5359ba9 · GitHub
[go: up one dir, main page]
Skip to content

Commit 5359ba9

Browse files
AbhiPrasadAbhiPrasad
authored
feat(tracing|core): Remove transaction name change recording (getsentry#7197)
1 parent 4c07d02 commit 5359ba9

File tree

23 files changed

+2
-307
lines changed

23 files changed

+2
-307
lines changed

‎packages/core/src/baseclient.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -545,15 +545,6 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
545545
processedEvent.transaction_info = {
546546
...transactionInfo,
547547
source,
548-
changes: [
549-
...transactionInfo.changes,
550-
{
551-
source,
552-
// use the same timestamp as the processed event.
553-
timestamp: processedEvent.timestamp as number,
554-
propagations: transactionInfo.propagations,
555-
},
556-
],
557548
};
558549
}
559550

‎packages/core/test/lib/base.test.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,8 +1368,6 @@ describe('BaseClient', () => {
13681368
type: 'transaction',
13691369
transaction_info: {
13701370
source: 'url',
1371-
changes: [],
1372-
propagations: 3,
13731371
},
13741372
};
13751373

@@ -1383,14 +1381,6 @@ describe('BaseClient', () => {
13831381
expect(TestClient.instance!.event!.transaction).toEqual('/adopt/dont/shop');
13841382
expect(TestClient.instance!.event!.transaction_info).toEqual({
13851383
source: 'custom',
1386-
changes: [
1387-
{
1388-
propagations: 3,
1389-
source: 'custom',
1390-
timestamp: expect.any(Number),
1391-
},
1392-
],
1393-
propagations: 3,
13941384
});
13951385
});
13961386

@@ -1407,23 +1397,13 @@ describe('BaseClient', () => {
14071397
type: 'transaction',
14081398
transaction_info: {
14091399
source: 'url',
1410-
changes: [],
1411-
propagations: 3,
14121400
},
14131401
});
14141402

14151403
expect(beforeSendTransaction).toHaveBeenCalled();
14161404
expect(TestClient.instance!.event!.transaction).toBe('/adopt/dont/shop');
14171405
expect(TestClient.instance!.event!.transaction_info).toEqual({
14181406
source: 'custom',
1419-
changes: [
1420-
{
1421-
propagations: 3,
1422-
source: 'custom',
1423-
timestamp: expect.any(Number),
1424-
},
1425-
],
1426-
propagations: 3,
14271407
});
14281408
});
14291409

‎packages/nextjs/test/integration/test/server/errorServerSideProps.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ describe('Error Server-side Props', () => {
4848
transaction: '/withErrorServerSideProps',
4949
transaction_info: {
5050
source: 'route',
51-
changes: [],
52-
propagations: 0,
5351
},
5452
type: 'transaction',
5553
request: {

‎packages/nextjs/test/integration/test/server/tracing200.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ describe('Tracing 200', () => {
2121
transaction: 'GET /api/users',
2222
transaction_info: {
2323
source: 'route',
24-
changes: [],
25-
propagations: 0,
2624
},
2725
type: 'transaction',
2826
request: {

‎packages/nextjs/test/integration/test/server/tracing500.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ describe('Tracing 500', () => {
2121
transaction: 'GET /api/broken',
2222
transaction_info: {
2323
source: 'route',
24-
changes: [],
25-
propagations: 0,
2624
},
2725
type: 'transaction',
2826
request: {

‎packages/nextjs/test/integration/test/server/tracingHttp.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ describe('Tracing HTTP', () => {
3333
transaction: 'GET /api/http',
3434
transaction_info: {
3535
source: 'route',
36-
changes: [],
37-
propagations: 1,
3836
},
3937
type: 'transaction',
4038
request: {

‎packages/nextjs/test/integration/test/server/tracingServerGetInitialProps.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ describe('getInitialProps', () => {
2020
transaction: '/[id]/withInitialProps',
2121
transaction_info: {
2222
source: 'route',
23-
changes: [],
24-
propagations: 0,
2523
},
2624
type: 'transaction',
2725
request: {

‎packages/nextjs/test/integration/test/server/tracingServerGetServerSideProps.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ describe('getServerSideProps', () => {
2020
transaction: '/[id]/withServerSideProps',
2121
transaction_info: {
2222
source: 'route',
23-
changes: [],
24-
propagations: 0,
2523
},
2624
type: 'transaction',
2725
request: {

‎packages/nextjs/test/integration/test/server/tracingServerGetServerSidePropsCustomPageExtension.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ describe('tracingServerGetServerSidePropsCustomPageExtension', () => {
2020
transaction: '/customPageExtension',
2121
transaction_info: {
2222
source: 'route',
23-
changes: [],
24-
propagations: 0,
2523
},
2624
type: 'transaction',
2725
request: {

‎packages/nextjs/test/integration/test/server/tracingWithSentryAPI.test.ts

Lines changed: 0 additions & 2 deletions
6F6F
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ describe('getServerSideProps', () => {
5454
transaction: `GET ${transactionName}`,
5555
transaction_info: {
5656
source: 'route',
57-
changes: [],
58-
propagations: 0,
5957
},
6058
type: 'transaction',
6159
request: {

0 commit comments

Comments
 (0)
0