8000 Remove basePath: "/" by navinger · Pull Request #1444 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Remove basePath: "/" #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2018
Merged

Remove basePath: "/" #1444

merged 1 commit into from
Apr 17, 2018

Conversation

navinger
Copy link
Contributor
@navinger navinger commented Apr 9, 2018

We need to remove this from all OpenAPI specs in the getting-started sample.
From the OpenAPI 2 spec:

  • basePath: "If it is not included, the API is served directly under the host. The value MUST start with a leading slash (/). "
  • Paths for methods: "A relative path to an individual endpoint. The field name MUST begin with a slash. The path is appended to the basePath in order to construct the full URL."

This OpenAPI getting-started sample have basePath="/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.

@navinger
Remove basePath: "/"
bfa3c70 
We need to remove this from all OpenAPI specs in the getting-started sample.
From the OpenAPI 2 spec:
* basePath: "If it is not included, the API is served directly under the host. The value MUST start with a leading slash (/). "
* Paths for methods: "A relative path to an individual endpoint. The field name MUST begin with a slash. The path is appended to the basePath in order to construct the full URL."

This OpenAPI getting-started sample have basePath="/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2018
@simonz130 simonz130 self-requested a review April 17, 2018 05:09
@simonz130 simonz130 requested a review from andrewsg April 17, 2018 05:12
@andrewsg andrewsg merged commit e985305 into GoogleCloudPlatform:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@simonz130 simonz130 simonz130 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navinger @andrewsg @simonz130 @googlebot
0