8000 gae: lead with gae_ in region tags by anguillanneuf · Pull Request #3795 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

gae: lead with gae_ in region tags #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

gae: lead with gae_ in region tags #3795

merged 1 commit into from
Sep 22, 2020

Conversation

anguillanneuf
Copy link
Member

These two samples aren't published on any Pub/Sub page, so their region tags should lead with gae_.

Page they appear: https://cloud.google.com/appengine/docs/flexible/java/writing-and-responding-to-pub-sub-messages

Will submit (cl/333179348) to update docs when this is merged.

@anguillanneuf anguillanneuf requested a review from a team September 22, 2020 23:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
@anguillanneuf anguillanneuf merged commit 69b9460 into master Sep 22, 2020
@anguillanneuf anguillanneuf deleted the region_tags branch September 22, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anguillanneuf @averikitsch
0