8000 Bigtable:Adding __eq__ and __ne__ methods for row set by sumit-ql · Pull Request #6025 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Bigtable:Adding __eq__ and __ne__ methods for row set #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 4 commits into from
Sep 20, 2018
Merged

Bigtable:Adding __eq__ and __ne__ methods for row set #6025

tseaver merged 4 commits into from
Sep 20, 2018

Conversation

@sumit-ql
Copy link
Contributor
@sumit-ql sumit-ql commented Sep 19, 2018
  1. eq and ne methods for RowSet and RowRange.
  2. Unit tests.

@sumit-ql sumit-ql requested a review from theacodes as a code owner September 19, 2018 16:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2018
tseaver
tseaver suggested changes Sep 19, 2018
View reviewed changes
bigtable/google/cloud/bigtable/row_set.py
return False

if not sorted(other.row_keys) == sorted(self.row_keys):
return False

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/row_set.py Outdated
try:
row_ranges.remove(each)
except ValueError:
return False

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver reviewed Sep 20, 2018
View reviewed changes
bigtable/google/cloud/bigtable/row_set.py
self.start_inclusive,
self.end_key,
self.end_inclusive,
)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit 16a358e into googleapis:master Sep 20, 2018
@sumit-ql sumit-ql deleted the implement-__eq__-for-row_set branch September 21, 2018 15:10
parthea pushed a commit that referenced this pull request Nov 22, 2025
@sumit-ql @tseaver
Bigtable: Add '{RowSet,RowRange}.{__eq__,.__ne__}' (#6025)
2a8e116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theacodes theacodes Awaiting requested review from theacodes

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sumit-ql @tseaver @googlebot
0