10BC0 BigQuery: add reference property to Table and Dataset by tswast · Pull Request #4405 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

BigQuery: add reference property to Table and Dataset #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2017
Merged

BigQuery: add reference property to Table and Dataset #4405

merged 2 commits into from
Nov 21, 2017

Conversation

tswast
Copy link
Contributor
@tswast tswast commented Nov 17, 2017

This makes it easier to call get_table, get_dataset, or other
functions that want just a reference, not a full resource.

Closes #4327

@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Nov 17, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2017
@tswast tswast mentioned this pull request Nov 17, 2017
Closed
@robfraz
Copy link
robfraz commented Nov 20, 2017

Thanks! LGTM (for what it's worth).

@tswast tswast requested a review from andrewsg November 20, 2017 18:19
@tswast tswast mentioned this pull request Nov 20, 2017
Merged
tswast
tswast commented Nov 21, 2017
8000 View reviewed changes
bigquery/google/cloud/bigquery/table.py Outdated
return self._table_id

@property
def reference(self):

This comment was marked as spam.

Sign in to view

@tswast
BigQuery: add reference property to Table and Dataset
9dad69c 
This makes it easier to call `get_table`, `get_dataset`, or other
functions that want just a reference, not a full resource.
@tswast
Use shared reference property between Table and TableListItem.
99b2137
@tswast tswast merged commit 58b642e into googleapis:master Nov 21, 2017
@tswast tswast deleted the bq-tableref branch November 21, 2017 21:29
@tseaver tseaver mentioned this pull request Jan 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@tseaver tseaver Awaiting requested review from tseaver

@dhermes dhermes Awaiting requested review from dhermes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tswast @robfraz @andrewsg @googlebot
0